Re: [PATCH] soc: mediatek: SCPSYS: use builtin_platform_driver

From	Daniel Kurtz <djkurtz@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] soc: mediatek: SCPSYS: use builtin_platform_driver
Date	2015-12-22 14:40 +0100
Message-ID	<qIvku-4y4-29@gated-at.bofh.it> (permalink)
References	<qIvkt-4y4-5@gated-at.bofh.it> <qIvkt-4y4-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Matthias,

One thing below is missing from this version of the patch...

> On Fri, Dec 18, 2015 at 7:19 PM, Matthias Brugger
> <matthias.bgg@gmail.com> wrote:
>> SCPSYS can't be built as module. Use builtin_platform_driver instead.
>> For this probe must not be __init and the data accessed can't be
>> __initconst. Remove this macros. To make the impact as small as possible,
>> fold scp_domain_data into scp_domain via a pointer.

[snip]

>> @@ -542,10 +533,11 @@ static const struct of_device_id of_scpsys_match_tbl[] = {
>>  };
>>
>>  static struct platform_driver scpsys_drv = {
>> +       .probe = scpsys_probe,
>>         .driver = {
>>                 .name = "mtk-scpsys",

This was in Sascha's version of the patch:

  .suppress_bind_attrs = true,

Do we still need it now that we use "builtin_platform_driver"?

>>                 .owner = THIS_MODULE,
>>                 .of_match_table = of_match_ptr(of_scpsys_match_tbl),
>>         },
>>  };
>> -builtin_platform_driver_probe(scpsys_drv, scpsys_probe);
>> +builtin_platform_driver(scpsys_drv);
>> --
>> 2.6.2
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] soc: mediatek: SCPSYS: use builtin_platform_driver Daniel Kurtz <djkurtz@chromium.org> - 2015-12-22 14:40 +0100
  Re: [PATCH] soc: mediatek: SCPSYS: use builtin_platform_driver Daniel Kurtz <djkurtz@chromium.org> - 2015-12-22 14:40 +0100
    Re: [PATCH] soc: mediatek: SCPSYS: use builtin_platform_driver Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-22 17:00 +0100

csiph-web