Re: [RFC PATCH V2 1/8] irqdomain: Ensure type settings match for an existing mapping

From	Grygorii Strashko <grygorii.strashko@ti.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH V2 1/8] irqdomain: Ensure type settings match for an existing mapping
Date	2015-12-22 12:40 +0100
Message-ID	<qItsm-3ml-19@gated-at.bofh.it> (permalink)
References	(1 earlier) <qGErW-6H4-51@gated-at.bofh.it> <qGGDo-8kx-11@gated-at.bofh.it> <qH0iK-4hR-15@gated-at.bofh.it> <qIrTB-2h1-19@gated-at.bofh.it> <qIs3g-2zy-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/22/2015 12:00 PM, Linus Walleij wrote:
> On Tue, Dec 22, 2015 at 10:58 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>> On Fri, Dec 18, 2015 at 11:10 AM, Jon Hunter <jonathanh@nvidia.com> wrote:
>>> On 17/12/15 13:16, Linus Walleij wrote:
>>>> On Thu, Dec 17, 2015 at 11:48 AM, Jon Hunter <jonathanh@nvidia.com> wrote:
>>>>> +               } else {
>>>>> +                       virq = irq_domain_alloc_descs(-1, 1, hwirq,
>>>>> +                                                     of_node_to_nid(of_node));
>>>>
>>>> What is this all of a sudden? Not even mentioned in the
>>>> commit. Plus I bet ACPI need something else than OF nid
>>>> passed here.
>>>
>>> Do you mean the else part of all of the above?
>>
>> Yes
>>
>>> So in the current code, the else part calls irq_create_mapping() (...)
>>
>> No, not that... The fact that you all of a sudden have started
>> calling irq_domain_alloc_descs() which the function didn't do
>> before, totally changing the calling semantics for everyone in
>> the kernel, leading to the problem I then describe with this
>> potentially being called before the irqdomain for the irqchip
>> is initialized and descs getting "random" numbers.
> 
> I see I didn't go into those details in my first answer. Hm, I
> guess I got uncertain and deleted it because I remember
> writing it...
> 
> I am simply worries that starting to call irq_domain_alloc_descs()
> has unintended side effects, especially on platforms using
> legacy or simple irqdomains.
> 

I think, some misunderstanding here introduced by replacing
irq_create_mapping() call on subset of direct calls to
irq_domain_alloc_descs() and irq_domain_associate().

-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH V2 1/8] irqdomain: Ensure type settings match for an existing mapping Jon Hunter <jonathanh@nvidia.com> - 2015-12-17 12:00 +0100
  Re: [RFC PATCH V2 1/8] irqdomain: Ensure type settings match for an  existing mapping Linus Walleij <linus.walleij@linaro.org> - 2015-12-17 14:20 +0100
    Re: [RFC PATCH V2 1/8] irqdomain: Ensure type settings match for an  existing mapping Jon Hunter <jonathanh@nvidia.com> - 2015-12-18 11:20 +0100
      Re: [RFC PATCH V2 1/8] irqdomain: Ensure type settings match for an  existing mapping Linus Walleij <linus.walleij@linaro.org> - 2015-12-22 11:00 +0100
        Re: [RFC PATCH V2 1/8] irqdomain: Ensure type settings match for an  existing mapping Linus Walleij <linus.walleij@linaro.org> - 2015-12-22 11:10 +0100
          Re: [RFC PATCH V2 1/8] irqdomain: Ensure type settings match for an  existing mapping Jon Hunter <jonathanh@nvidia.com> - 2015-12-22 12:30 +0100
          Re: [RFC PATCH V2 1/8] irqdomain: Ensure type settings match for an  existing mapping Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-22 12:40 +0100

csiph-web