Re: [PATCH v3 23/77] ncr5380: Always retry arbitration and selection

Path	csiph.com!news.mixmin.net!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Hannes Reinecke <hare@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 23/77] ncr5380: Always retry arbitration and selection
Date	Tue, 22 Dec 2015 08:20:02 +0100
Message-ID	<qIpoK-Py-17@gated-at.bofh.it> (permalink)
References	<qIl1L-6kS-3@gated-at.bofh.it> <qIl1M-6kS-13@gated-at.bofh.it>
X-Original-To	Finn Thain <fthain@telegraphics.com.au>, "James E.J. Bottomley" <JBottomley@odin.com>, Michael Schmitz <schmitzmic@gmail.com>, linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" <martin.petersen@oracle.com>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Date	Tue, 22 Dec 2015 08:14:59 +0100
X-Original-Message-ID	<5678F873.2020005@suse.de>
X-Original-References	<20151222011737.980475848@telegraphics.com.au> <20151222011744.275507291@telegraphics.com.au>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1296590

Show key headers only | View raw

On 12/22/2015 02:18 AM, Finn Thain wrote:
> If NCR5380_select() returns -1, it means arbitration was lost or selection
> failed and should be retried. If the main loop simply terminates when there
> are still commands on the issue queue, they will remain queued until they
> expire.
>
> Fix this by clearing the 'done' flag after selection failure or lost
> arbitration.
>
> The "else break" clause in NCR5380_main() that gets removed here appears
> to be a vestige of a long-gone loop that iterated over host instances.
> See commit 491447e1fcff ("[PATCH] next NCR5380 updates") in
> history/history.git.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 23/77] ncr5380: Always retry arbitration and selection Finn Thain <fthain@telegraphics.com.au> - 2015-12-22 03:40 +0100
  Re: [PATCH v3 23/77] ncr5380: Always retry arbitration and selection Hannes Reinecke <hare@suse.de> - 2015-12-22 08:20 +0100

csiph-web