Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1296561

Re: [PATCH] Revert "kernel/stop_machine.c: remove CONFIG_SMP dependencies"

Show all headers | View raw

On Fri, Dec 18, 2015 at 03:07:53PM -0800, Andrew Morton wrote:
> On Fri, 18 Dec 2015 15:35:55 +0530 Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
> 
> > This reverts commit 64dab25b058c12f935794cb239089303bda7dbc1.
> > 
> > CONFIG_SMP dependency is needed for some arch like tile, tilegx and
> > m32r. They use stop_machine() but they donot have HOTPLUG_CPU and as a
> > result their builds are failing with "undefined symbol 'stop_machine'".
> 
> Thanks.  I had my &&'s and ||'s mixed up.   I did this:
> 
> --- a/kernel/stop_machine.c~kernel-stop_machinec-remove-config_smp-dependencies-fix
> +++ a/kernel/stop_machine.c
> @@ -531,8 +531,6 @@ static int __init cpu_stop_init(void)
>  }
>  early_initcall(cpu_stop_init);
>  
> -#ifdef CONFIG_HOTPLUG_CPU
> -
>  static int __stop_machine(cpu_stop_fn_t fn, void *data, const struct cpumask *cpus)
>  {
>  	struct multi_stop_data msdata = {
> @@ -630,5 +628,3 @@ int stop_machine_from_inactive_cpu(cpu_s
>  	mutex_unlock(&stop_cpus_mutex);
>  	return ret ?: done.ret;
>  }
> -
> -#endif	/* CONFIG_HOTPLUG_CPU */
> _
> 
> 
> Rationale:
> 
> stop_machine.o is only built when CONFIG_SMP=y so
> 
> #if defined(CONFIG_SMP) || defined(CONFIG_HOTPLUG_CPU)
> 
> always evaluates to true, so remove it.

Hi Andrew,
The error is still there. I guess you have been busy. :)

next-20151222 fails with the same error. You can see the m32r defconfig
at https://travis-ci.org/sudipm-mukherjee/parport/jobs/98258267

do you want me to send the patch to you for it?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "kernel/stop_machine.c: remove CONFIG_SMP dependencies" Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-18 11:10 +0100
  Re: [PATCH] Revert "kernel/stop_machine.c: remove CONFIG_SMP  dependencies" Chris Metcalf <cmetcalf@ezchip.com> - 2015-12-18 16:00 +0100
  Re: [PATCH] Revert  "kernel/stop_machine.c: remove CONFIG_SMP dependencies" Andrew Morton <akpm@linux-foundation.org> - 2015-12-19 00:10 +0100
    Re: [PATCH] Revert "kernel/stop_machine.c: remove CONFIG_SMP  dependencies" Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-22 07:10 +0100
      Re: [PATCH] Revert  "kernel/stop_machine.c: remove CONFIG_SMP dependencies" Andrew Morton <akpm@linux-foundation.org> - 2015-12-22 08:10 +0100
        Re: [PATCH] Revert "kernel/stop_machine.c: remove CONFIG_SMP  dependencies" Stephen Rothwell <sfr@canb.auug.org.au> - 2015-12-22 21:10 +0100

csiph-web