Re: [RFC] mm: change find_vma() function

From	yalin wang <yalin.wang2010@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC] mm: change find_vma() function
Date	2015-12-22 06:40 +0100
Message-ID	<qInPY-8dk-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <qFAgG-61e-11@gated-at.bofh.it> <qFFzJ-Ts-33@gated-at.bofh.it> <qFIHg-382-31@gated-at.bofh.it> <qFRAS-pw-9@gated-at.bofh.it> <qFWqR-3yI-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On Dec 15, 2015, at 19:53, Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:
> 
> On Tue, Dec 15, 2015 at 02:41:21PM +0800, yalin wang wrote:
>>> On Dec 15, 2015, at 05:11, Kirill A. Shutemov <kirill@shutemov.name> wrote:
>>> Anyway, I don't think it's possible to gain anything measurable from this
>>> optimization.
>>> 
>> the advantage is that if addr don’t belong to any vma, we don’t need loop all vma,
>> we can break earlier if we found the most closest vma which vma->end_add > addr,
> 
> Do you have any workload which can demonstrate the advantage?
> 
> — 
i add the log in find_vma() to see the call stack ,
it is very efficient in mmap() / munmap / do_execve() / get_unmaped_area() /
mem_cgroup_move_task()->walk_page_range()->find_vma() call ,

in most time the loop will break after search about 7 vm,
i don’t consider the cache pollution problem in this patch,
yeah, this patch will check the vm_prev->vm_end for every loop,
but this only happened when tmp->vm_end > addr ,
if you don’t not check this , you will continue to loop to check next rb ,
this will also pollute the cache ,

so the question is which one is better ?
i don’t have a better method to test this .
Any good ideas about this ?
how to test it ?

Thanks







--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC] mm: change find_vma() function yalin wang <yalin.wang2010@gmail.com> - 2015-12-14 12:10 +0100
  Re: [RFC] mm: change find_vma() function "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-12-14 13:20 +0100
    Re: [RFC] mm: change find_vma() function Oleg Nesterov <oleg@redhat.com> - 2015-12-14 19:00 +0100
      Re: [RFC] mm: change find_vma() function "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-12-14 22:20 +0100
        Re: [RFC] mm: change find_vma() function yalin wang <yalin.wang2010@gmail.com> - 2015-12-15 07:50 +0100
          Re: [RFC] mm: change find_vma() function Andrea Arcangeli <aarcange@redhat.com> - 2015-12-15 12:50 +0100
          Re: [RFC] mm: change find_vma() function "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2015-12-15 13:00 +0100
            Re: [RFC] mm: change find_vma() function yalin wang <yalin.wang2010@gmail.com> - 2015-12-22 06:40 +0100

csiph-web