[POC][PATCH 42/83] simserial: get rid of pointless casts

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	[POC][PATCH 42/83] simserial: get rid of pointless casts
Date	2015-12-22 01:10 +0100
Message-ID	<qIiGE-50N-49@gated-at.bofh.it> (permalink)
References	<qIing-4Eb-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Al Viro <viro@zeniv.linux.org.uk>

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 arch/ia64/hp/sim/simserial.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/ia64/hp/sim/simserial.c b/arch/ia64/hp/sim/simserial.c
index 6e81449..7c3871e 100644
--- a/arch/ia64/hp/sim/simserial.c
+++ b/arch/ia64/hp/sim/simserial.c
@@ -364,19 +364,20 @@ static int activate(struct tty_port *port, struct tty_struct *tty)
 {
 	struct serial_state *state = container_of(port, struct serial_state,
 			port);
-	unsigned long flags, page;
+	unsigned long flags;
+	unsigned char *page;
 	int retval = 0;
 
-	page = (unsigned long)get_zeroed_page(GFP_KERNEL);
+	page = get_zeroed_page(GFP_KERNEL);
 	if (!page)
 		return -ENOMEM;
 
 	local_irq_save(flags);
 
 	if (state->xmit.buf)
-		free_page((void *)page);
+		free_page(page);
 	else
-		state->xmit.buf = (unsigned char *) page;
+		state->xmit.buf = page;
 
 	if (state->irq) {
 		retval = request_irq(state->irq, rs_interrupt_single, 0,
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[POC][PATCH 42/83] simserial: get rid of pointless casts Al Viro <viro@ZenIV.linux.org.uk> - 2015-12-22 01:10 +0100

csiph-web