Re: [PATCH 03/04] pinctrl: sh-pfc: r8a7794: Add missing dot clock signals

Path	csiph.com!news.mixmin.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/04] pinctrl: sh-pfc: r8a7794: Add missing dot clock signals
Date	Mon, 21 Dec 2015 23:10:01 +0100
Message-ID	<qIgOt-3Ob-1@gated-at.bofh.it> (permalink)
References	<qvEYh-7Qv-7@gated-at.bofh.it> <qvEYi-7Qv-17@gated-at.bofh.it>
X-Original-To	Magnus Damm <magnus.damm@gmail.com>, linux-sh@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=65ee97KreXlCVjo6HijW+MwlEkJpzLc6Gu2EpCrzois=; b=dK3o63qVjK4wNOWuCvqV5NTBPmNOHicn1dVEnYNY/vGCIOuoinylo5cWwiBkyFJNsA HQKOOVUvnZLvcwP0zwRpI06mrZkzBj5jcaY4rDO/fb/sfimSMIFS6TZeG9q2G2FMnQfh O1hTPuhIy7PO8sFNXdQHIWp3r/MkTgfREEB0ds2fcrZAsjLOUGRc9vGDXXI6Xcv2mY4i z6aX5LaVcMPszQto6loFbZijKHKHFPCNLrSG/RA9Hg7L8LNrmgJu8Ppsbt+bNIxwWfzm qhkUXuzY9U5MZpqC1bU4pYgsp8HKhNA0UCpgIk/IiwgawgJrXfK5cBk6PAP81uD1tOmP o+3w==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:organization :message-id:date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=65ee97KreXlCVjo6HijW+MwlEkJpzLc6Gu2EpCrzois=; b=GFVcmd7FeT4BAcO1ZPIU9hrypibPrGT+vsOwE5jhcOOypkYCo8E358veb+jlj2x3b7 SoE+V3hW4dNfftQC1hRdDAoJjwDJjf/MbKhrymaA1lA30IGHA+zf1isZofbw2F5oxxbM I/3s0470Pw91p5TICJMCsa3rz15Jo8vDXxt0PqM9LZR5IF/axsA8ylHzPOhb6ZJyOovI yn3EFhxCM+GiztB4aKJwf4BxDZYwGOfULxoot1nmXAtG28IkXQDH1ZycebdIHXqtM1pJ tI1/l5LMH+DPbht2hGMtq6kVroDke8UDfgvIwZKhcX8Y2gPNoUOjd8SP9XL8U0CMnPbd L8gw==
X-Gm-Message-State	ALoCoQnrHGqSt/nYrmemJnpyqibJMmfwyeliYUqO7mQBrBretOoB2lDRk3aesw1Syxi18imL7FahdahqGUsInaF8aH7ZCFW+SA==
X-Received	by 10.112.142.70 with SMTP id ru6mr7244297lbb.51.1450735297696; Mon, 21 Dec 2015 14:01:37 -0800 (PST)
Organization	Cogent Embedded
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	70
X-Original-Cc	linus.walleij@linaro.org, linux-kernel@vger.kernel.org, koji.matsuoka.xm@renesas.com, linux-gpio@vger.kernel.org, horms@verge.net.au, geert@glider.be, laurent.pinchart@ideasonboard.com
X-Original-Date	Tue, 22 Dec 2015 01:01:34 +0300
X-Original-Message-ID	<567876BE.60100@cogentembedded.com>
X-Original-References	<20151117031832.24924.60685.sendpatchset@little-apple> <20151117031902.24924.4588.sendpatchset@little-apple>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1296241

Show key headers only | View raw

Hello.

On 11/17/2015 06:19 AM, Magnus Damm wrote:

> From: Magnus Damm <damm+renesas@opensource.se>
>
> Add missing r8a7794 DU dot clock output signals and in
> particular the DU1_DOTCLKOUT0 signal on GP4_25 which is
> needed by DU1 on the r8a7794 ALT board.
>
> The groups "du0_clk_out" and "du1_clk_out" are replaced by
> "du0_dotclkout0", "du0_dotclkout1", "du1_dotclkout0" and
> "du1_dotclkout1".
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
>
>   drivers/pinctrl/sh-pfc/pfc-r8a7794.c |   34 ++++++++++++++++++++++++++--------
>   1 file changed, 26 insertions(+), 8 deletions(-)
>
> --- 0014/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
> +++ work/drivers/pinctrl/sh-pfc/pfc-r8a7794.c	2015-11-16 22:08:28.230513000 +0900
[...]
> @@ -2942,8 +2956,10 @@ static const struct sh_pfc_pin_group pin
>   	SH_PFC_PIN_GROUP(du0_rgb888),
>   	SH_PFC_PIN_GROUP(du1_rgb666),
>   	SH_PFC_PIN_GROUP(du1_rgb888),
> -	SH_PFC_PIN_GROUP(du0_clk_out),
> -	SH_PFC_PIN_GROUP(du1_clk_out),
> +	SH_PFC_PIN_GROUP(du0_clk0_out),
> +	SH_PFC_PIN_GROUP(du0_clk1_out),
> +	SH_PFC_PIN_GROUP(du1_clk0_out),
> +	SH_PFC_PIN_GROUP(du1_clk1_out),

    Hm, this kinda contradicts your chngnelog, no?

>   	SH_PFC_PIN_GROUP(du0_sync),
>   	SH_PFC_PIN_GROUP(du1_sync),
>   	SH_PFC_PIN_GROUP(du0_cde),
> @@ -3134,8 +3150,10 @@ static const char * const du_groups[] =
>   	"du0_rgb888",
>   	"du1_rgb666",
>   	"du1_rgb888",
> -	"du0_clk_out",
> -	"du1_clk_out",
> +	"du0_dotclkout0",
> +	"du0_dotclkout1",
> +	"du1_dotclkout0",
> +	"du1_dotclkout1",
>   	"du0_sync",
>   	"du1_sync",
>   	"du0_cde",

    I'm getting the following on the SILK board with this patch:

[drm] Initialized drm 1.1.0 20060810
sh-pfc e6060000.pin-controller: does not have pin group du1_dotclkout0
sh-pfc e6060000.pin-controller: invalid group du1_dotclkout0 in map table
[drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
[drm] No driver support for vblank timestamp query.
rcar-du feb00000.display: fb0:  frame buffer device
[drm] Initialized rcar-du 1.0.0 20130110 on minor 0

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 03/04] pinctrl: sh-pfc: r8a7794: Add missing dot clock  signals Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-21 23:10 +0100

csiph-web