Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware
Date	2015-12-21 18:40 +0100
Message-ID	<qIcBc-11j-15@gated-at.bofh.it> (permalink)
References	<qH2aR-5vD-5@gated-at.bofh.it> <qH2aR-5vD-3@gated-at.bofh.it> <qIc89-Ry-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 21, 2015 at 05:04:11PM +0000, Bryan O'Donoghue wrote:
> > This patch also export efi_capsule_supported() function symbol for
> > verifying the submitted capsule header in this kernel module.
> 
> 1. Should be a separate patch 
> 2. Suggested, rewording for that patch log
> 
> 2/2 Title
> This patch exports efi_capsule_supported to enable verification of the
> capsule header.
> 
> That said - who is the user of this symbol ? Why is it needed ? Anyway
> please consider splitting and rewording.

Huh?

I still don't really see the reasoning for splitting out the export.

When you do the export and use it in a single patch it is *obvious* why
it is being exported.

And there's no need to mention in the commit message that you're
exporting a symbol. People export symbols all the time.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v10 1/1] efi: a misc char interface for user to update efi firmware "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2015-12-18 13:20 +0100
  Re: [PATCH v10 1/1] efi: a misc char interface for user to update  efi firmware Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2015-12-21 18:10 +0100
    Re: [PATCH v10 1/1] efi: a misc char interface for user to update  efi firmware Borislav Petkov <bp@alien8.de> - 2015-12-21 18:40 +0100
      Re: [PATCH v10 1/1] efi: a misc char interface for user to update  efi firmware Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2015-12-21 18:50 +0100

csiph-web