Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer

From	Pratyush Anand <panand@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer
Date	2015-12-21 17:20 +0100
Message-ID	<qIblN-jv-15@gated-at.bofh.it> (permalink)
References	<qGFR0-7NE-3@gated-at.bofh.it> <qGFR0-7NE-1@gated-at.bofh.it> <qGIca-Ma-13@gated-at.bofh.it> <qHhjA-6Mt-3@gated-at.bofh.it> <qIb2q-8oD-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 21/12/2015:07:52:59 AM, Guenter Roeck wrote:
> On 12/18/2015 08:22 PM, Pratyush Anand wrote:
> >On 17/12/2015:06:56:27 AM, Guenter Roeck wrote:
> >>On 12/17/2015 04:23 AM, Pratyush Anand wrote:
> >>>We need few sysfs attributes to know different status of a watchdog device.
> >>>To do that, we need to associate .dev_groups with watchdog_class. So
> >>>convert it from pointer to static.
> >>>Putting this static struct in watchdog_dev.c, so that static device
> >>>attributes defined in that file can be attached to it.
> >>>
> >>>Signed-off-by: Pratyush Anand <panand@redhat.com>
> >>>Suggested-by: Guenter Roeck <linux@roeck-us.net>
> >>>Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> >>
> >>As things evolve, I'd by now prefer to move the call to device_create()
> >>into watchdog_dev.c, but that can wait for a follow-up patch if Wim
> >>is ok with this series.
> >
> >Thanks for your quick review.
> >
> >OK. I will wait for Wim's comment and then may be I will send another
> >version with your comment for patch 1/1 incorporated.
> >
> 
> Thinking about it, my comment is really minor and should not hold up the
> series from going forward. So let's just skip another version unless Wim
> or someone else has any comments.

Thanks a lot :-)

~Pratyush
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer Pratyush Anand <panand@redhat.com> - 2015-12-17 13:30 +0100
  Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class  in stead of pointer Guenter Roeck <linux@roeck-us.net> - 2015-12-17 16:00 +0100
    Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class  in stead of pointer Pratyush Anand <panand@redhat.com> - 2015-12-19 05:30 +0100
      Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class  in stead of pointer Guenter Roeck <linux@roeck-us.net> - 2015-12-19 17:30 +0100
      Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class  in stead of pointer Guenter Roeck <linux@roeck-us.net> - 2015-12-21 17:00 +0100
        Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class  in stead of pointer Pratyush Anand <panand@redhat.com> - 2015-12-21 17:20 +0100

csiph-web