Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1297343

Re: [PATCH powerpc/next v6 0/4] atomics: powerpc: Implement relaxed/acquire/release variants

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Dec 23, 2015 at 01:40:05PM +1100, Michael Ellerman wrote:
> On Tue, 2015-12-15 at 22:24 +0800, Boqun Feng wrote:
> 
> > Hi all,
> > 
> > This is v6 of the series.
> > 
> > Link for v1: https://lkml.org/lkml/2015/8/27/798
> > Link for v2: https://lkml.org/lkml/2015/9/16/527
> > Link for v3: https://lkml.org/lkml/2015/10/12/368
> > Link for v4: https://lkml.org/lkml/2015/10/14/670
> > Link for v5: https://lkml.org/lkml/2015/10/26/141
> > 
> > 
> > Changes since v5:
> > 
> > *	rebase on the next branch of powerpc.
> > 
> > *	pull two fix and one testcase patches out, which are already
> > 	sent separately
> > 
> > *	some clean up or code format fixing.
> > 
> > 
> > Paul, Peter and Will, thank you for your comments and suggestions in the review
> > of previous versions. From this version on, This series is against the next
> > branch of powerpc tree, because most of the code touch arch/powerpc/*.
> 
> 
> Sorry if we already discussed this, but did we decide how we were going to
> merge this? There's the one patch to generic code and then three powerpc
> patches.
> 
> It'd make most sense for it to go via powerpc I think. Given that the change to
> generic code is relatively trivial I'll plan to merge this unless someone
> objects.
> 
> Also it is pretty late in the -next cycle for something like this. But AFAICS
> there are no users of these "atomic*relaxed" variants yet other than arm64 code
> and qspinlocks, neither of which are used on powerpc. So adding them should be
> pretty harmless.
> 

There is one thing we should be aware of, that is the bug:

http://lkml.kernel.org/r/5669D5F2.5050004@caviumnetworks.com

which though has been fixed by:

http://lkml.kernel.org/r/20151217160549.GH6344@twins.programming.kicks-ass.net

but the fix is not in powerpc/next right now. As this patchset makes
atomic_xchg_acquire a real ACQUIRE, so we will also trigger that bug if
this series gets merged in the next branch of powerpc tree, though
that's not the problem of this patchset.

Not sure whether this is a problem for your maintence, but just think
it's better to make you aware of this ;-)

Regards,
Boqun

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH powerpc/next v6 0/4] atomics: powerpc: Implement relaxed/acquire/release variants Boqun Feng <boqun.feng@gmail.com> - 2015-12-15 15:30 +0100
  [PATCH v6 4/4] powerpc: atomic: Implement acquire/release/relaxed variants for cmpxchg Boqun Feng <boqun.feng@gmail.com> - 2015-12-15 15:30 +0100
  [PATCH v6 1/4] atomics: Allow architectures to define their own __atomic_op_* helpers Boqun Feng <boqun.feng@gmail.com> - 2015-12-15 15:30 +0100
  [PATCH v6 3/4] powerpc: atomic: Implement acquire/release/relaxed variants for xchg Boqun Feng <boqun.feng@gmail.com> - 2015-12-15 15:50 +0100
  [PATCH v6 2/4] powerpc: atomic: Implement atomic{,64}_*_return_* variants Boqun Feng <boqun.feng@gmail.com> - 2015-12-15 15:50 +0100
  Re: [PATCH powerpc/next v6 0/4] atomics: powerpc: Implement  relaxed/acquire/release variants Davidlohr Bueso <dave@stgolabs.net> - 2015-12-18 18:20 +0100
    Re: [PATCH powerpc/next v6 0/4] atomics: powerpc: Implement  relaxed/acquire/release variants Boqun Feng <boqun.feng@gmail.com> - 2015-12-20 08:20 +0100
  Re: [PATCH powerpc/next v6 0/4] atomics: powerpc: Implement  relaxed/acquire/release variants Michael Ellerman <mpe@ellerman.id.au> - 2015-12-23 03:50 +0100
    Re: [PATCH powerpc/next v6 0/4] atomics: powerpc: Implement  relaxed/acquire/release variants Boqun Feng <boqun.feng@gmail.com> - 2015-12-23 04:40 +0100
    Re: [PATCH powerpc/next v6 0/4] atomics: powerpc: Implement  relaxed/acquire/release variants Boqun Feng <boqun.feng@gmail.com> - 2015-12-23 12:00 +0100
      Re: [PATCH powerpc/next v6 0/4] atomics: powerpc: Implement  relaxed/acquire/release variants Davidlohr Bueso <dave@stgolabs.net> - 2015-12-23 13:20 +0100
      Re: [PATCH powerpc/next v6 0/4] atomics: powerpc: Implement  relaxed/acquire/release variants Michael Ellerman <mpe@ellerman.id.au> - 2015-12-27 09:00 +0100
        Re: [PATCH powerpc/next v6 0/4] atomics: powerpc: Implement  relaxed/acquire/release variants Boqun Feng <boqun.feng@gmail.com> - 2015-12-28 03:50 +0100

csiph-web