Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled

From	Oliver Neukum <oneukum@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled
Date	2015-12-23 11:50 +0100
Message-ID	<qIP9w-8u4-15@gated-at.bofh.it> (permalink)
References	(3 earlier) <qIrJT-2dB-1@gated-at.bofh.it> <qIsZj-3ag-5@gated-at.bofh.it> <qIIro-4oC-5@gated-at.bofh.it> <qIMY2-7ed-9@gated-at.bofh.it> <qINU6-7NH-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2015-12-23 at 09:20 +0000, Hayes Wang wrote:
> Oliver Neukum [mailto:oneukum@suse.de]
> > Sent: Wednesday, December 23, 2015 4:20 PM
> [...]
> > No, step (2) does not exist. Calls to suspend() and [reset_]resume()
> > always balance. Usually a driver shouldn't care about system suspend.
> > The way the driver is currently coded will also fail for Port-Power Off.
> 
> It is different with Windows. The Windows would resume the device before
> system suspend, if the system suspend follows the autosuspend.
> 
> Would this be a problem? After system suspend, the device may wake up
> the system when receiving any packet, not only magic packet. The wake
> events are different for system suspend and autosuspend. However, I
> couldn't change the wake event, because the autosuspend occurs first,
> and the suspend() is only called once.

That is indeed a problem and I need to think a bit about finding
a good solution. If you are happy with an inelegant solution, you can
use a pm_notifier, which will tell you that the system is going
to suspend. This is documented:

https://www.kernel.org/doc/Documentation/power/notifiers.txt

	HTH
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled Hayes Wang <hayeswang@realtek.com> - 2015-12-22 10:50 +0100
  Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled Oliver Neukum <oneukum@suse.com> - 2015-12-22 12:10 +0100
    RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled Hayes Wang <hayeswang@realtek.com> - 2015-12-23 04:40 +0100
      Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled Oliver Neukum <oneukum@suse.de> - 2015-12-23 09:30 +0100
        RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled Hayes Wang <hayeswang@realtek.com> - 2015-12-23 10:30 +0100
          Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled Oliver Neukum <oneukum@suse.com> - 2015-12-23 11:50 +0100
            RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled Hayes Wang <hayeswang@realtek.com> - 2015-12-23 12:20 +0100
          RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled Alan Stern <stern@rowland.harvard.edu> - 2015-12-24 02:40 +0100
            Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled Oliver Neukum <oneukum@suse.com> - 2015-12-24 08:20 +0100
              Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled Alan Stern <stern@rowland.harvard.edu> - 2015-12-24 16:20 +0100
                Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled Oliver Neukum <oneukum@suse.com> - 2015-12-24 16:50 +0100
                Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled Alan Stern <stern@rowland.harvard.edu> - 2015-12-24 17:10 +0100

csiph-web