Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1297320

Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

Show all headers | View raw

On 21/12/2015 at 10:24:08 +0100, Ludovic Desroches wrote :
> +++ b/Documentation/devicetree/bindings/iio/adc/at91_adc8xx.txt
> @@ -0,0 +1,27 @@
> +* AT91 SAMA5D2 Analog to Digital Converter (ADC)
> +
> +Required properties:
> +  - compatible: Should be "atmel,sama5d2-adc".
> +  - reg: Should contain ADC registers location and length.
> +  - interrupts: Should contain the IRQ line for the ADC.
> +  - clocks: phandles to clocks.
> +  - clock-names: tuple listing clock names.
> +      Required elements: "adc_clk", "adc_op_clk". "adc_clk" is the peripheral
> +      clock, "adc_clk" is the sampling clock.

I think we should not have adc_op_clk but rather have a property like
vf610 has fsl,adck-max-frequency.
Even better, would be the ability to change it with
/sys/bus/iio/devices/iio:deviceX/sampling_frequency


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] Introduce at91_adc8xx driver Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-12-21 10:30 +0100
  [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-12-21 10:30 +0100
    Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Jonathan Cameron <jic23@kernel.org> - 2015-12-22 19:40 +0100
      Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-12-23 11:30 +0100
        Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-12-23 11:50 +0100
          Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2015-12-23 18:30 +0100
        Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Jonathan Cameron <jic23@kernel.org> - 2015-12-31 20:30 +0100
    Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Rob Herring <robh@kernel.org> - 2015-12-23 02:00 +0100
      Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-12-23 11:30 +0100
    Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-12-23 11:30 +0100

csiph-web