Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1297299

Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move rockchip to use it

Show all headers | View raw

On Tue, 22 Dec 2015 17:38:00 +0000
Liviu Dudau <Liviu.Dudau@arm.com> wrote:

> On Fri, Nov 20, 2015 at 02:22:03PM +0000, Liviu Dudau wrote:
> > Hello,
> > 
> > This is v2 of the patchset trying to make drm_of_component_probe() cope with finding
> > both local crtc ports and remote encoder ones. Heiko Stübner was nice enough to test
> > an earlier version that was patched following Russell's suggestions on rk3288, but
> > I haven't seen any reports from iMX or Armada users.
> > 
> > Changelog:
> >  v2: Updated the drm_of_component_probe() comment to explain why the reference count
> >      is not dropped. Fixed the compare_port() function for rockchip as described by
> >      Russell.
> >  v1: Original submission. http://lists.freedesktop.org/archives/dri-devel/2015-November/094546.html
> 
> Gentle ping, this has now been tested by Rockchip people and fixes the earlier version
> that had to be reverted in mainline. Can it be included in the -next somewhere?

Hi Liviu,

Sorry for being a bit late.

I wanted to use drm_of_component_probe() for a new DRM driver, but I
could not find any way to do it: you add the "ports" nodes as
components while, usually, the components are the device nodes
themselves.

With this simple patch:

diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
index 493c05c..dbd2921 100644
--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -101,7 +101,7 @@ int drm_of_component_probe(struct device *dev,
 			continue;
 		}
 
-		component_match_add(dev, &match, compare_of, port);
+		component_match_add(dev, &match, compare_of, port->parent);
 		of_node_put(port);
 	}
 
everything is easy, my DT being like:

	de_controller {
		...
		ports = <&lcd0_p>;
	};

	lcd_controller {
		...
		lcd0_p: port {
			lcd0_ep: endpoint {
				remote-endpoint = <&hdmi_ep>;
			};
		};
	};

What was the reason to keep the "ports" node instead of the device?

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move  rockchip to use it Liviu Dudau <Liviu.Dudau@arm.com> - 2015-12-22 18:40 +0100
  Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move rockchip  to use it Dave Airlie <airlied@gmail.com> - 2015-12-23 02:40 +0100
  Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move  rockchip to use it Jean-Francois Moine <moinejf@free.fr> - 2015-12-23 10:40 +0100
    Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move  rockchip to use it Liviu Dudau <Liviu.Dudau@arm.com> - 2015-12-23 11:10 +0100
      Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move  rockchip to use it Jean-Francois Moine <moinejf@free.fr> - 2015-12-23 18:30 +0100
        Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move  rockchip to use it Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-23 20:10 +0100
          Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move  rockchip to use it Jean-Francois Moine <moinejf@free.fr> - 2015-12-24 09:20 +0100
            Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move  rockchip to use it Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-24 12:00 +0100
              Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move  rockchip to use it Jean-Francois Moine <moinejf@free.fr> - 2015-12-24 13:30 +0100
                Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move  rockchip to use it Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-24 13:40 +0100
                Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move  rockchip to use it Jean-Francois Moine <moinejf@free.fr> - 2015-12-25 10:40 +0100

csiph-web