Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1297239

Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply

Show all headers | View raw

Hi Jingoo,

On 12/22/2015 08:26 PM, Jingoo Han wrote:
> On Wednesday, December 16, 2015 12:58 PM, Yakir Yang wrote:
>> After test on rockchiop platform, i found sometims driver would failed
>> at reading EDID message. After debugging more, i found that it's okay
>> to read_a byte from i2c, but it would failed at AUX transcation if we
>> try to ready multi-bytes from i2c.
>>
>> Driver just can't received the AUX CH reply command, even no AUX error
>> code. I may guess that the AUX wait time is not enough, so I try to
>> expand the AUX wait time, and i do see this could fix the EDID read
>> failed at rockchip platform.
>>
>> And I thought that expand the wait time won't hurt Exynos platform too
>> much, cause Exynos didn't have this problem, then driver would received
>> the reply command very soon, so no more additional wait time would bring
>> to Exynos platform.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v11: None
>> Changes in v10: None
>> Changes in v9: None
>> Changes in v8: None
>> Changes in v7: None
>> Changes in v6: None
>> Changes in v5: None
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>>   drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> index c7e2959..dc376bd 100644
>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> @@ -482,7 +482,7 @@ int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp)
>>   	reg = readl(dp->reg_base + ANALOGIX_DP_INT_STA);
>>   	while (!(reg & RPLY_RECEIV)) {
>>   		timeout_loop++;
>> -		if (DP_TIMEOUT_LOOP_COUNT < timeout_loop) {
>> +		if (DP_TIMEOUT_LOOP_COUNT * 10 < timeout_loop) {
> No, I hate this coding.
> analogix_dp_reg.c is the common code that can be shared by various SoCs.
> Please, find another way.

Okay, I have double checked that i do have this problem in my side. 
Hmmm.....
I thought it's okay for you if I expand the "DP_TIMEOUT_LOOP_COUNT" 
directly,
it won't hurt Exynos platform too much, cause Exynos didn't have this 
problem,
then driver would received,the reply command very soon, so no more 
additional
wait time would bring to Exynos platform.

And actually the datasheet haven't described the spec of aux reply delay 
time.

Thanks,
- Yakir

> Best regards,
> Jingoo Han
>
>
>>   			dev_err(dp->dev, "AUX CH command reply failed!\n");
>>   			return -ETIMEDOUT;
>>   		}
>> --
>> 1.9.1
>
>
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v11 0/19] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-12-16 04:30 +0100
  [PATCH v11 02/19] drm: bridge: analogix/dp: fix some obvious code style Yakir Yang <ykk@rock-chips.com> - 2015-12-16 04:30 +0100
    Re: [PATCH v11 02/19] drm: bridge: analogix/dp: fix some obvious code style "Jingoo Han" <jingoohan1@gmail.com> - 2015-12-22 13:10 +0100
      Re: [PATCH v11 02/19] drm: bridge: analogix/dp: fix some obvious code  style Yakir Yang <ykk@rock-chips.com> - 2015-12-23 02:00 +0100
  [PATCH v11 03/19] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang <ykk@rock-chips.com> - 2015-12-16 04:40 +0100
    Re: [PATCH v11 03/19] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count "Jingoo Han" <jingoohan1@gmail.com> - 2015-12-22 13:10 +0100
      Re: [PATCH v11 03/19] drm: bridge: analogix/dp: remove duplicate  configuration of link rate and link count Yakir Yang <ykk@rock-chips.com> - 2015-12-23 01:50 +0100
  [PATCH v11 05/19] dt-bindings: add document for analogix display port driver Yakir Yang <ykk@rock-chips.com> - 2015-12-16 04:40 +0100
  [PATCH v11 04/19] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang <ykk@rock-chips.com> - 2015-12-16 04:40 +0100
  [PATCH v11 06/19] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang <ykk@rock-chips.com> - 2015-12-16 04:40 +0100
    Re: [PATCH v11 06/19] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver "Jingoo Han" <jingoohan1@gmail.com> - 2015-12-22 13:20 +0100
      Re: [PATCH v11 06/19] ARM: dts: exynos/dp: remove some properties  that deprecated by analogix_dp driver Yakir Yang <ykk@rock-chips.com> - 2015-12-23 01:50 +0100
  [PATCH v11 07/19] drm: rockchip: dp: add rockchip platform dp driver Yakir Yang <ykk@rock-chips.com> - 2015-12-16 04:40 +0100
  [PATCH v11 08/19] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-12-16 04:50 +0100
  [PATCH v11 11/19] drm: rockchip: vop: add bpc and color mode setting Yakir Yang <ykk@rock-chips.com> - 2015-12-16 04:50 +0100
  [PATCH v11 10/19] dt-bindings: add document for rockchip dp phy Yakir Yang <ykk@rock-chips.com> - 2015-12-16 04:50 +0100
  [PATCH v11 09/19] phy: Add driver for rockchip Display Port PHY Yakir Yang <ykk@rock-chips.com> - 2015-12-16 04:50 +0100
    Re: [PATCH v11 09/19] phy: Add driver for rockchip Display Port PHY "Jingoo Han" <jingoohan1@gmail.com> - 2015-12-22 13:30 +0100
      Re: [PATCH v11 09/19] phy: Add driver for rockchip Display Port PHY Yakir Yang <ykk@rock-chips.com> - 2015-12-23 01:50 +0100
  [PATCH v11 16/19] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang <ykk@rock-chips.com> - 2015-12-16 05:00 +0100
  [PATCH v11 14/19] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-12-16 05:00 +0100
  [PATCH v11 15/19] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang <ykk@rock-chips.com> - 2015-12-16 05:00 +0100
  [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply Yakir Yang <ykk@rock-chips.com> - 2015-12-16 05:00 +0100
    Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply "Jingoo Han" <jingoohan1@gmail.com> - 2015-12-22 13:30 +0100
      Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time  for waiting AUX CH reply Yakir Yang <ykk@rock-chips.com> - 2015-12-23 05:30 +0100
        Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time  for waiting AUX CH reply Yakir Yang <ykk@rock-chips.com> - 2015-12-23 07:10 +0100
          Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply "Jingoo Han" <jingoohan1@gmail.com> - 2015-12-23 16:20 +0100
  [PATCH v11 13/19] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang <ykk@rock-chips.com> - 2015-12-16 05:00 +0100
  [PATCH v11 12/19] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang <ykk@rock-chips.com> - 2015-12-16 05:00 +0100
  [PATCH v11 19/19] drm: bridge: analogix/dp: Fix the possible dead lock in bridge disable time Yakir Yang <ykk@rock-chips.com> - 2015-12-16 05:10 +0100
  [PATCH v11 18/19] drm: bridge: analogix/dp: add panel prepare/unprepare in suspend/resume time Yakir Yang <ykk@rock-chips.com> - 2015-12-16 05:10 +0100
  Re: [PATCH v11 0/19] Add Analogix Core Display Port Driver Heiko Stübner <heiko@sntech.de> - 2015-12-18 01:00 +0100
    Re: [PATCH v11 0/19] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-12-18 01:40 +0100

csiph-web