Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1297203

Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp

Show all headers | View raw

On Wed, 2015-12-23 at 11:56 +1100, Finn Thain wrote:
> On Tue, 22 Dec 2015, Joe Perches wrote:
> 
> > On Tue, 2015-12-22 at 12:18 +1100, Finn Thain wrote:
> > > This patch is just the result of two substitutions. The first removes 
> > > any tabs and spaces at the end of the line. The second replaces runs 
> > > of tabs and spaces at the beginning of comment lines with a single 
> > > space.
> > 
> > I think the second of these isn't done well.
> 
> The aim of this patch is not to fix code style, but to make it possible to 
> compare these two files so that the fork can be repaired. Regexp is very 
> helpful in creating uniformity (and a minimal diff).
> 
> If this was a coding style issue, we would be discussing the use of 
> kernel-doc format for the affected comments, not whitespace.
> 
> > Many of these comments post reformatting are
> > much worse to read because of lost alignment.
> 
> You exaggerate a very trivial point.

<shrug>

I prefer that all patches be improvements.

> I admit that a small proportion of comments are slightly less readable. 
> But it is the diff that needs to be readable in order to resolve the fork.

diff -w works well.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/77] More fixes, cleanup and modernization for NCR5380 drivers Finn Thain <fthain@telegraphics.com.au> - 2015-12-22 04:00 +0100
  [PATCH v3 08/77] ncr5380: Move NCR53C400-specific code Finn Thain <fthain@telegraphics.com.au> - 2015-12-22 04:00 +0100
  [PATCH v3 11/77] ncr5380: Simplify bus reset handlers Finn Thain <fthain@telegraphics.com.au> - 2015-12-22 04:00 +0100
  [PATCH v3 12/77] ncr5380: Remove unused hostdata->aborted flag Finn Thain <fthain@telegraphics.com.au> - 2015-12-22 04:00 +0100
  [PATCH v3 14/77] ncr5380: Use return instead of goto in NCR5380_select() Finn Thain <fthain@telegraphics.com.au> - 2015-12-22 04:00 +0100
  [PATCH v3 09/77] atari_NCR5380: Reset bus on driver initialization if required Finn Thain <fthain@telegraphics.com.au> - 2015-12-22 04:00 +0100
  [PATCH v3 15/77] ncr5380: Always escalate bad target time-out in NCR5380_select() Finn Thain <fthain@telegraphics.com.au> - 2015-12-22 04:00 +0100
  [PATCH v3 05/77] ncr5380: Remove NCR5380_local_declare and NCR5380_setup macros Finn Thain <fthain@telegraphics.com.au> - 2015-12-22 04:00 +0100
  [PATCH v3 10/77] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY and CONFIG_ATARI_SCSI_RESET_BOOT Finn Thain <fthain@telegraphics.com.au> - 2015-12-22 04:00 +0100
  [PATCH v3 07/77] ncr5380: Split NCR5380_init() into two functions Finn Thain <fthain@telegraphics.com.au> - 2015-12-22 04:00 +0100
  Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp Joe Perches <joe@perches.com> - 2015-12-22 15:50 +0100
    Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp Finn Thain <fthain@telegraphics.com.au> - 2015-12-23 02:00 +0100
      Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp Joe Perches <joe@perches.com> - 2015-12-23 02:20 +0100
        Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp Finn Thain <fthain@telegraphics.com.au> - 2015-12-23 03:10 +0100
          Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp Joe Perches <joe@perches.com> - 2015-12-23 03:20 +0100
            Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp Finn Thain <fthain@telegraphics.com.au> - 2015-12-23 05:20 +0100
      Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-12-23 02:30 +0100
        Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp Finn Thain <fthain@telegraphics.com.au> - 2015-12-23 03:40 +0100
  Re: [PATCH v3 00/77] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-12-22 21:20 +0100
  Re: [PATCH v3 00/77] More fixes, cleanup and modernization for  NCR5380 drivers Michael Schmitz <schmitzmic@gmail.com> - 2016-01-01 02:30 +0100

csiph-web