Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1297042

RE: [PATCH 1/4] x86/efi: show actual ending addresses in efi_print_memmap

Show all headers | View raw

---
Robert Elliott, HPE Persistent Memory


> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Matt Fleming
> Sent: Monday, December 21, 2015 10:06 AM
> To: Elliott, Robert (Persistent Memory) <elliott@hpe.com>
> Cc: tglx@linutronix.de; mingo@redhat.com; hpa@zytor.com; x86@kernel.org;
> linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/4] x86/efi: show actual ending addresses in
> efi_print_memmap
> 
> On Mon, 21 Dec, at 03:50:38PM, Matt Fleming wrote:
> > On Thu, 17 Dec, at 07:28:31PM, Robert Elliott wrote:
> > > Adjust efi_print_memmap to print the real end address of each
> > > range, not 1 byte beyond. This matches other prints like those for
> > > SRAT and nosave memory.
> > >
> > > Change the closing ) to ] to match the opening [.
> > >
> > > old:
> > >     efi: mem61: [Persistent Memory  |   |  |  |  |  |  |
> |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c80000000) (16384MB)
> > >
> > > new:
> > >     efi: mem61: [Persistent Memory  |   |  |  |  |  |  |
> |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c7fffffff] (16384MB)
> > >
> > > Example other address range prints:
> > >     SRAT: Node 1 PXM 1 [mem 0x480000000-0x87fffffff]
> > >     PM: Registered nosave memory: [mem 0x880000000-0xc7fffffff]
> > >
> > > Signed-off-by: Robert Elliott <elliott@hpe.com>
> > > ---
> > >  arch/x86/platform/efi/efi.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Is this change purely for aesthetic reasons? We're usually not in the
> > habit of changing the output of print messages without a good reason
> > because people downstream do rely on them being consistent.
> 
> I just noticed the bracket change.
> 
> My comment above only refers to printing the range addresses. Swapping
> ')' for ']' is a perfectly valid change.

While investigating the grub persistent memory corruption
issues, it was helpful to make this table match the ending
address convention used by:
* the kernel's e820 table prints
* the kernel's nosave memory prints
* grub's lsmmap and lsefimmap commands
* the UEFI shell's memmap command

Using the excerpts from the patch, if you grep all the various
logs for c7fffffff, you won't find the line with c80000000.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

(none) Robert Elliott <elliott@hpe.com> - 2015-12-18 01:30 +0100
  [PATCH 2/4] efi: add NV memory attribute Robert Elliott <elliott@hpe.com> - 2015-12-18 01:30 +0100
    Re: [PATCH 2/4] efi: add NV memory attribute Matt Fleming <matt@codeblueprint.co.uk> - 2015-12-21 17:00 +0100
  [PATCH 4/4] x86/efi: print size and base in binary units in efi_print_memmap Robert Elliott <elliott@hpe.com> - 2015-12-18 01:30 +0100
    Re: [PATCH 4/4] x86/efi: print size and base in binary units in  efi_print_memmap Matt Fleming <matt@codeblueprint.co.uk> - 2015-12-21 17:20 +0100
      RE: [PATCH 4/4] x86/efi: print size and base in binary units in  efi_print_memmap "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2015-12-23 01:20 +0100
        Re: [PATCH 4/4] x86/efi: print size and base in binary units in  efi_print_memmap Matt Fleming <matt@codeblueprint.co.uk> - 2015-12-23 17:00 +0100
      Re: [PATCH 4/4] x86/efi: print size and base in binary units in efi_print_memmap Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-27 15:40 +0100
  [PATCH 1/4] x86/efi: show actual ending addresses in efi_print_memmap Robert Elliott <elliott@hpe.com> - 2015-12-18 01:30 +0100
    Re: [PATCH 1/4] x86/efi: show actual ending addresses in  efi_print_memmap Matt Fleming <matt@codeblueprint.co.uk> - 2015-12-21 17:00 +0100
      Re: [PATCH 1/4] x86/efi: show actual ending addresses in  efi_print_memmap Matt Fleming <matt@codeblueprint.co.uk> - 2015-12-21 17:10 +0100
        RE: [PATCH 1/4] x86/efi: show actual ending addresses in  efi_print_memmap "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2015-12-22 21:10 +0100
          Re: [PATCH 1/4] x86/efi: show actual ending addresses in  efi_print_memmap Matt Fleming <matt@codeblueprint.co.uk> - 2015-12-23 13:50 +0100
      RE: [PATCH 1/4] x86/efi: show actual ending addresses in  efi_print_memmap "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2015-12-21 17:50 +0100
        Re: [PATCH 1/4] x86/efi: show actual ending addresses in  efi_print_memmap Matt Fleming <matt@codeblueprint.co.uk> - 2015-12-23 13:50 +0100
          [PATCH v2 1/4] x86/efi: show actual ending addresses in efi_print_memmap Robert Elliott <elliott@hpe.com> - 2015-12-24 01:10 +0100

csiph-web