Re: [PATCH] iio: exynos-adc: fix irqf_oneshot.cocci warnings

From	Olof Johansson <olof@lixom.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iio: exynos-adc: fix irqf_oneshot.cocci warnings
Date	2015-12-22 20:10 +0100
Message-ID	<qIAtQ-7UX-29@gated-at.bofh.it> (permalink)
References	<qBbgR-4Mq-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 02, 2015 at 09:43:10AM +0100, Valentin Rothberg wrote:
> Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
> threaded IRQs without a primary handler need to be requested with
> IRQF_ONESHOT, otherwise the request will fail.
> 
> So pass the IRQF_ONESHOT flag in this case.
> 
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> ---
> 
> The patch looks fine to me: bad things can happen when interrupts are
> acked before the handler ran.

Hi,

Applied. Thanks.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] iio: exynos-adc: fix irqf_oneshot.cocci warnings Olof Johansson <olof@lixom.net> - 2015-12-22 20:10 +0100

csiph-web