Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1297014

Re: [PATCH v5] bus: uniphier-system-bus: add UniPhier System Bus driver

From Olof Johansson <olof@lixom.net>
Newsgroups linux.kernel
Subject Re: [PATCH v5] bus: uniphier-system-bus: add UniPhier System Bus driver
Date 2015-12-22 20:40 +0100
Message-ID <qIAWR-86s-15@gated-at.bofh.it> (permalink)
References <qDGTg-4SH-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Dec 09, 2015 at 03:52:59PM +0900, Masahiro Yamada wrote:
> The UniPhier System Bus is an external bus that connects on-board
> devices to the UniPhier SoC.  Each bank (chip select) is dynamically
> mapped to the CPU-viewed address base via the bus controller.  The
> bus controller must be configured before any access to the bus.
> 
> This driver parses the "ranges" property of the System Bus node and
> initialized the bus controller.  After the bus becomes ready, devices
> below it are populated.
> 
> Note:
> Each bank can be mapped anywhere in the supported address space;
> there is nothing preventing us from assigning bank 0 on 0x42000000,
> 0x43000000, or anywhere as long as such region is not used by others.
> So, the "ranges" is just one possible software configuration, which
> does not seem to fit in device tree because device tree is a hardware
> description language.  However, of_translate_address() requires
> "ranges" in every bus node between CPUs and device mapped on the CPU
> address space.  In other words, "ranges" properties must be statically
> defined in device tree.  After some discussion, I decided the dynamic
> address reassignment by the driver is too bothersome.  Instead, the
> device tree should provide a reasonable translation setup that the OS
> can rely on.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied to next/drivers.


-Olof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v5] bus: uniphier-system-bus: add UniPhier System Bus  driver Olof Johansson <olof@lixom.net> - 2015-12-22 20:40 +0100

csiph-web