Re: linux-next: build failure after merge of the rtc tree

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: linux-next: build failure after merge of the rtc tree
Date	2015-12-22 20:30 +0100
Message-ID	<qIANc-81O-5@gated-at.bofh.it> (permalink)
References	<qGyZb-3kJ-1@gated-at.bofh.it> <qGEUW-79i-23@gated-at.bofh.it> <qH5iq-7rE-35@gated-at.bofh.it> <qH6oa-86R-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Sasha,

On 18/12/2015 at 17:43:41 +0100, Alexandre Belloni wrote :
> > > Sasha, I think I prefer having 32 bit platforms fail on the 21st of
> > > January 11761191 rather than adding more uses of do_div in the function.
> > > I'll have a look at the performance impact on 32 bit platforms.
> > 
> > I'm really fine with just adding a WARN_ON() and aborting if it's the year
> > 11761191 :)
> > 
> 
> One simple way to solve it for 64bit platforms is to define days as
> unsigned long. Maybe throw a comment that it will fail for 32bit
> platforms in January 11761191 ;).
> 

I did that:

http://git.kernel.org/cgit/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=0d3da1806b985f1100615c2c09033b404941b63e

Unless you disagree, that is what I'm planning to send to Linus.

I wish you a happy end of year.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the rtc tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-12-17 06:10 +0100
  Re: linux-next: build failure after merge of the rtc tree Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-12-17 12:30 +0100
    Re: linux-next: build failure after merge of the rtc tree Sasha Levin <sasha.levin@oracle.com> - 2015-12-18 16:40 +0100
      Re: linux-next: build failure after merge of the rtc tree Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-12-18 17:50 +0100
        Re: linux-next: build failure after merge of the rtc tree Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-12-22 20:30 +0100

csiph-web