Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Yakir Yang <ykk@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support
Date	Mon, 21 Dec 2015 08:50:02 +0100
Message-ID	<qI3oe-3AX-1@gated-at.bofh.it> (permalink)
References	<qtyki-8g4-5@gated-at.bofh.it> <qtykh-8g4-3@gated-at.bofh.it> <qI3ex-3xA-5@gated-at.bofh.it>
X-Original-To	Mark yao <mark.yao@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>
X-263anti-Spam	KSV:0;
X-Mail-Gray	1
X-Abs-Checked	4
X-Rl-Sender	ykk@rock-chips.com
X-Fst-To	linux-arm-kernel@lists.infradead.org
X-Sender-IP	103.29.142.67
X-Login-Name	ykk@rock-chips.com
X-Unique-Tag	<8b140dd8632eace0bfe67b207680e4df>
X-Sender	ykk@rock-chips.com
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	David Airlie <airlied@linux.ie>, Thierry Reding <treding@nvidia.com>, Rob Herring <robh+dt@kernel.org>, Ken Mixte <kmixter@google.com>, Ben Chan <benchan@google.com>, Zheng Yang <zhengyang@rock-chips.com>, Kumar Gala <galak@codeaurora.org>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org
X-Original-Date	Mon, 21 Dec 2015 15:44:56 +0800
X-Original-Message-ID	<5677ADF8.60305@rock-chips.com>
X-Original-References	<1447227952-4787-1-git-send-email-ykk@rock-chips.com> <1447227999-4842-1-git-send-email-ykk@rock-chips.com> <5677AAC4.1010405@rock-chips.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1295802

Show key headers only | View raw

Hi Mark,

On 12/21/2015 03:31 PM, Mark yao wrote:
> On 2015年11月11日 15:46, Yakir Yang wrote:
>> +    hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD;
>> +
>> +    drm_connector_helper_add(&hdmi->connector,
>> +                 &inno_hdmi_connector_helper_funcs);
>> +    drm_connector_init(drm, &hdmi->connector, 
>> &inno_hdmi_connector_funcs,
>> +               DRM_MODE_CONNECTOR_HDMIA);
>> +
>> +    hdmi->connector.encoder = encoder;
>
> Pls remove "hdmi->connector.encoder = encoder;"
>
> It would cause a error dump on atomic drm runtime:
>
> WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 
> drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200()
>
> This issue can be explained from following thread:
> https://lkml.org/lkml/2015/11/16/498
>

Done, thanks

- Yakir

> Thanks.
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support Mark yao <mark.yao@rock-chips.com> - 2015-12-21 08:40 +0100
  Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI  support Yakir Yang <ykk@rock-chips.com> - 2015-12-21 08:50 +0100

csiph-web