Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1295463

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

Show all headers | View raw

Hello.

On 12/19/2015 11:15 PM, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 19 Dec 2015 21:10:20 +0100
>
> The return type "u32" was used by the fhci_create_ep() function even though
> it will eventually return a negative error code.
> Improve this implementation detail by using the type "s32" instead.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>   drivers/usb/host/fhci-tds.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c
> index f82ad5d..c1ae172 100644
> --- a/drivers/usb/host/fhci-tds.c
> +++ b/drivers/usb/host/fhci-tds.c
> @@ -149,7 +149,7 @@ void fhci_ep0_free(struct fhci_usb *usb)
>    * data_mem	The data memory partition(BUS)
>    * ring_len	TD ring length
>    */
> -u32 fhci_create_ep(struct fhci_usb *usb, enum fhci_mem_alloc data_mem,
> +s32 fhci_create_ep(struct fhci_usb *usb, enum fhci_mem_alloc data_mem,

    Should be just *int*, I think.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] USB-FHCI: Use a signed return type for fhci_create_ep() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-19 21:20 +0100
  Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep() Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-19 21:30 +0100
    Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-19 22:00 +0100
      Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep() Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-19 22:10 +0100
    [PATCH v2 0/2] USB-FHCI: Use return type "int" for two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-22 16:50 +0100
      [PATCH v2 1/2] USB-FHCI: Use a signed return type for  fhci_create_ep() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-22 17:00 +0100
      [PATCH v2 2/2] USB-FHCI: Use a signed return type for  endpoint_zero_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-22 17:00 +0100
  Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep() Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-19 21:50 +0100

csiph-web