Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1295457

Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

Show all headers | View raw

On Sat, Dec 19, 2015 at 09:40:27PM +0100, SF Markus Elfring wrote:
> > This introduces a compile warning.
> 
> How do you think about to show the exact message you get?
> 

I can't actually compile it myself.

> 
> > These functions are supposed to return 1 if there is an IRQ pending.
> > Change the -EINVAL to 0.
> 
> Is there any more source code clean-up needed around the comment "FIXME"
> in the affected function?

Delete the FIXME comment.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl-adi2: Use a signed return type for  adi_gpio_irq_startup() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-19 18:10 +0100
  Re: [PATCH] pinctrl-adi2: Use a signed return type for  adi_gpio_irq_startup() Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-19 21:20 +0100
    Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup() Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-19 21:50 +0100
      Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-19 23:30 +0100
    Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-19 21:50 +0100
  Re: [PATCH] pinctrl-adi2: Use a signed return type for  adi_gpio_irq_startup() kbuild test robot <lkp@intel.com> - 2015-12-19 23:00 +0100

csiph-web