Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1295403

Re: [PATCH v3] Staging: iio: accel: Fixed NULL comparison style

Show all headers | View raw

On 13/12/15 15:15, Bhaktipriya Shridhar wrote:
> The variable u8 **rx_p, is a pointer-to-pointer and hence the check
> should
> be "if (!*rx_p)" and not "if (!rx_p)".
> In the earlier version, checkpatch.pl gave the following check, which
> was incorrect:
> CHECK: Comparison to NULL could be written "!rx_p"
> +       if (*rx_p == NULL) {
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Applied to the togreg branch of iio.git with the addition of the driver name
in the patch title.

Thanks

Jonathan
> ---
>  Changes in v3:
>         - Replaced "if (!rx_p)" with "if (!*rx_p)"
> 	- Changes are made on the original code
> 
>  drivers/staging/iio/accel/sca3000_ring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
> index 20b878d..1920dc60 100644
> --- a/drivers/staging/iio/accel/sca3000_ring.c
> +++ b/drivers/staging/iio/accel/sca3000_ring.c
> @@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
>  		}
>  	};
>  	*rx_p = kmalloc(len, GFP_KERNEL);
> -	if (*rx_p == NULL) {
> +	if (!*rx_p) {
>  		ret = -ENOMEM;
>  		goto error_ret;
>  	}
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] Staging: iio: accel: Fixed NULL comparison style Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2015-12-13 16:20 +0100
  Re: [PATCH v3] Staging: iio: accel: Fixed NULL comparison style Jonathan Cameron <jic23@kernel.org> - 2015-12-19 17:50 +0100

csiph-web