Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1295386
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints |
| Date | 2015-12-19 16:10 +0100 |
| Message-ID | <qHriW-4Nf-9@gated-at.bofh.it> (permalink) |
| References | <qFR7Q-fs-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 14 Dec 2015, Jeff Merkey wrote: > + /* > + * check if we got an execute breakpoint > + * from the dr7 register. if we did, set > + * the resume flag to avoid int1 recursion. Malformatted comment as any other comment you touched. > + */ > + if ((dr7 & (3 << ((i * 4) + 16))) == 0) > + args->regs->flags |= X86_EFLAGS_RF; This still uses magic numbers instead of the proper defines. I asked for that before. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V3] Fix INT1 Recursion with unregistered breakpoints Jeff Merkey <linux.mdb@gmail.com> - 2015-12-15 07:20 +0100
Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints Jeff Merkey <linux.mdb@gmail.com> - 2015-12-15 19:40 +0100
Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints Jeff Merkey <linux.mdb@gmail.com> - 2015-12-15 20:20 +0100
Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints Thomas Gleixner <tglx@linutronix.de> - 2015-12-19 16:10 +0100
Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints Jeff Merkey <linux.mdb@gmail.com> - 2015-12-19 23:30 +0100
Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints Jeff Merkey <linux.mdb@gmail.com> - 2015-12-20 00:20 +0100
csiph-web