Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1295328

Re: [PATCH] blackfin-cpufreq: Change return type of cpu_set_cclk() to that of clk_set_rate()

Show all headers | View raw

>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Fri, 18 Dec 2015 19:43:27 +0100
>>
>> The return type "unsigned long" was used by the cpu_set_cclk() function
>> while the type "int" is provided by the clk_set_rate() function.
>> Let us make this usage consistent.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>> ---
>>  drivers/cpufreq/blackfin-cpufreq.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/blackfin-cpufreq.c b/drivers/cpufreq/blackfin-cpufreq.c
>> index a9f8e5b..2a6f3ac 100644
>> --- a/drivers/cpufreq/blackfin-cpufreq.c
>> +++ b/drivers/cpufreq/blackfin-cpufreq.c
>> @@ -112,7 +112,7 @@ static unsigned int bfin_getfreq_khz(unsigned int cpu)
>>  }
>>  
>>  #ifdef CONFIG_BF60x
>> -unsigned long cpu_set_cclk(int cpu, unsigned long new)
>> +int cpu_set_cclk(int cpu, unsigned long new)
>>  {
>>  	struct clk *clk;
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Thanks for your acceptance.

I would appreciate if another implementation detail can also be clarified there.
http://lxr.free-electrons.com/ident?v=4.3;i=cpu_set_cclk

* Do you want to reuse such a function in other modules?
* Should it eventually marked as "static"?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] blackfin-cpufreq: Change return type of cpu_set_cclk() to  that of clk_set_rate() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-18 20:10 +0100
  Re: [PATCH] blackfin-cpufreq: Change return type of cpu_set_cclk()  to that of clk_set_rate() Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-19 03:10 +0100
    Re: [PATCH] blackfin-cpufreq: Change return type of cpu_set_cclk() to  that of clk_set_rate() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-19 09:30 +0100
      Re: [PATCH] blackfin-cpufreq: Change return type of cpu_set_cclk()  to that of clk_set_rate() Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-21 04:20 +0100
        Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static? Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-21 10:30 +0100
          Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static? Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-21 11:00 +0100
            Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static? Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-21 11:10 +0100
            Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static? SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-21 11:10 +0100
          Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static? SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-21 11:00 +0100
        Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static? SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-21 10:30 +0100
  [PATCH 0/2] blackfin-cpufreq: Fine-tuning for properties of one  function SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-21 22:30 +0100
    [PATCH 1/2] blackfin-cpufreq: Change return type of cpu_set_cclk() to  that of clk_set_rate() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-21 22:40 +0100
    [PATCH 2/2] blackfin-cpufreq: Mark cpu_set_cclk() as static SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-21 22:40 +0100
      Re: [PATCH 2/2] blackfin-cpufreq: Mark cpu_set_cclk() as static Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-22 06:40 +0100
        Re: blackfin-cpufreq: Mark cpu_set_cclk() as static SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-22 09:30 +0100
          Re: blackfin-cpufreq: Mark cpu_set_cclk() as static Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-22 09:40 +0100

csiph-web