Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1295275

[PATCH] ceph: Avoid to propagate the invalid page point

Path csiph.com!xmission!news.glorb.com!bofh.it!news.nic.it!robomod
From Minfei Huang <mnfhuang@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] ceph: Avoid to propagate the invalid page point
Date Sat, 19 Dec 2015 04:00:01 +0100
Message-ID <qHfUt-5Gv-1@gated-at.bofh.it> (permalink)
X-Original-To zyan@redhat.com, sage@redhat.com, idryomov@gmail.com
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=wucRrrz7BRUe3JxWpNHu+Fa/c7FjvhpeFbHfFjEq2aw=; b=Pic5U/wjMQaTdLFoPRSH1DAy0O52GyIC9gBsX8UHYAF2mOWjmHWP7V5C0bwb12pqeM /U0gX2HYOp4RO+DX5JRuYKJjIB3rK0Zgicx3aU1lFN5pXy6xwTVNUUO97kD2Ajzn51L8 Al8f+vK5/ygO1iG5Dj4WxKuamCDXi094SXgwZqAl95HwxbyzKmj6kqGz0c6gDMxn3s+c 0ZMIG8Uldp636Etr0SYI6T+G6X89b/ygnk0aDjd7wBbFYbRjTq29IxiM3TMEDG2z4MCc TIIoB63ZnibBbgYe5SssNDB96qEMWnwBl2Oi3lCLqU8CVhRi1X+rgpMcYHZ2KpvJKfNf iR8A==
X-Received by 10.98.43.79 with SMTP id r76mr10197240pfr.9.1450493696600; Fri, 18 Dec 2015 18:54:56 -0800 (PST)
X-Mailer git-send-email 2.6.3
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 31
Organization linux.* mail to news gateway
X-Original-Cc ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, mhuang@redhat.com, Minfei Huang <mnfhuang@gmail.com>
X-Original-Date Sat, 19 Dec 2015 10:54:59 +0800
X-Original-Message-ID <1450493699-20983-1-git-send-email-mnfhuang@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1295275

Show key headers only | View raw


The variant pagep will still get the invalid page point, although ceph
fails in function ceph_update_writeable_page.

To fix this issue, Assigne the page to pagep until there is no failure
in function ceph_update_writeable_page.

Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
---
 fs/ceph/addr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index b7d218a..6491079 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -1149,7 +1149,6 @@ static int ceph_write_begin(struct file *file, struct address_space *mapping,
 		page = grab_cache_page_write_begin(mapping, index, 0);
 		if (!page)
 			return -ENOMEM;
-		*pagep = page;
 
 		dout("write_begin file %p inode %p page %p %d~%d\n", file,
 		     inode, page, (int)pos, (int)len);
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] ceph: Avoid to propagate the invalid page point Minfei Huang <mnfhuang@gmail.com> - 2015-12-19 04:00 +0100
  Re: [PATCH] ceph: Avoid to propagate the invalid page point "Yan, Zheng" <zyan@redhat.com> - 2015-12-21 05:20 +0100

csiph-web