Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug
Date	Sat, 19 Dec 2015 01:50:01 +0100
Message-ID	<qHdSF-4si-3@gated-at.bofh.it> (permalink)
References	<pWo1Y-7ax-7@gated-at.bofh.it> <pYGH7-3Jf-1@gated-at.bofh.it> <pYTXI-61Z-13@gated-at.bofh.it> <q0IYa-1r5-17@gated-at.bofh.it> <q10in-T2-31@gated-at.bofh.it>
X-Original-To	Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=/19lvMIBY3sST5y7Axkp7avEJJuMgQ7WZ21JxiDSLLo=; b=DXPxtQcpbVvpyfuaT4r6uVsjWz6+T4vpa/SPXFJdW3EJdld19dDnD7buqojSoMahs7 CylScp7b+ssUReZv31M8wV8o0vVa9StOgvK3cHGP63B7+gHlAODERvbbWAe6SncAg+iw c2ZUxNbYGk19V1DrsUR3t4wcB+MFqcv7tfjo0tTt5Zk97qhcoXzMLJeLnDNKzjmdZm5j zRrFZewje2bc7Z1jT2vsd4nrb0ONVHuJQDbhqWQ6KJPLfvKcxvN9PiCP7LMWi7dKgY4Z 7crx+xk5mIIKTNFKKixptoIeKWoSWMZp4/GXKHjyk3iz+88mZ8Be0h2vaMEWuM4Df20C lNkg==
X-Received	by 10.66.240.97 with SMTP id vz1mr9639442pac.29.1450486127930; Fri, 18 Dec 2015 16:48:47 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	Robert Jarzmik <robert.jarzmik@free.fr>, Ezequiel Garcia <ezequiel.garcia@free-electrons.com>, David Woodhouse <dwmw2@infradead.org>, "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Fri, 18 Dec 2015 16:48:45 -0800
X-Original-Message-ID	<20151219004845.GW10460@google.com>
X-Original-References	<1439323034-8820-1-git-send-email-robert.jarzmik@free.fr> <20150818042426.GA27858@laptop> <874mjwa1w6.fsf@belgarion.home> <87r3mt3jpw.fsf@belgarion.home> <CAAEAJfD2NB+JkpwwcwRz6gWOfcNVEY2MqWGkCskf0a0WRNR9gQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1295250

Show key headers only | View raw

Garbage collecting some old patches before vacation...

On Mon, Aug 24, 2015 at 10:46:18AM -0300, Ezequiel Garcia wrote:
> I agree that the hack is useful for debugging purposes, it's just that I don't
> see why we want it in mainline - where we usually avoid clutter.

I'm not sure this is really that important of clutter. It's in a nicely
hidden abstraction (the local nand_{read,write}l() helpers), and it
doesn't add any compile time cost for most users.

> Also, your argument applies to all the other drivers, but that doesn't mean
> we will patch them all.
> 
> Anyway, this is just my opinion. If Brian thinks differently, I have no problem
> with it.

I don't have very strong opinions on this. It's kind of annoying to have
this sort of stuff duplicated for every driver, if it's really needed.
But I'll admit this kind of infrastructure is sometimes useful.

Anecdote: I recently found the regmap trace event infrastructure pretty
nice for debugging some other drivers. This would only require you to
have tracing enabled, and then no recompiles are necessary at all. Just
cmdline changes.

So, I could go with this patch, if Robert still desires it. Or you could
convert to using regmap for MMIO :)

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug Brian Norris <computersforpeace@gmail.com> - 2015-12-19 01:50 +0100
  Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug Robert Jarzmik <robert.jarzmik@free.fr> - 2015-12-19 13:20 +0100

csiph-web