Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1295233
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable |
| Date | 2015-12-19 00:10 +0100 |
| Message-ID | <qHcjU-3Fb-5@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <qEFiq-2CJ-11@gated-at.bofh.it> <qEFiq-2CJ-9@gated-at.bofh.it> <qH0iK-4hR-21@gated-at.bofh.it> <qH1ot-4X1-1@gated-at.bofh.it> <qH2aR-5vD-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 18 Dec 2015 13:11:41 +0100 Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Dec 18, 2015 at 12:29:02PM +0100, Peter Zijlstra wrote:
> > On Fri, Dec 18, 2015 at 10:18:08AM +0000, Daniel Thompson wrote:
> > > I'm not entirely sure that this is an improvement.
> >
> > What I do these days is delete everything in vprintk_emit() and simply
> > call early_printk().
>
> On that, whoever made the device model use vprintk_emit() broke the
> debugger (KGDB/KDB) printk intercept, and the whole vprintk_func
> redirection scheme.
crap, we have a whole set of interfaces which are broken this way.
printk_emit(), vprintk(), vprintk_emit().
commit 7ff9554bb578ba02166071d2d487b7fc7d860d62
Author: Kay Sievers <kay@vrfy.org>
AuthorDate: Thu May 3 02:29:13 2012 +0200
Commit: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CommitDate: Mon May 7 16:53:02 2012 -0700
printk: convert byte-buffer to variable-length record buffer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Jiri Kosina <jikos@kernel.org> - 2015-12-12 00:30 +0100
Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Daniel Thompson <daniel.thompson@linaro.org> - 2015-12-18 11:20 +0100
Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Peter Zijlstra <peterz@infradead.org> - 2015-12-18 12:30 +0100
Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Peter Zijlstra <peterz@infradead.org> - 2015-12-18 13:20 +0100
Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Andrew Morton <akpm@linux-foundation.org> - 2015-12-19 00:10 +0100
Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Petr Mladek <pmladek@suse.com> - 2015-12-18 16:00 +0100
Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Daniel Thompson <daniel.thompson@linaro.org> - 2015-12-18 18:10 +0100
csiph-web