Re: [PATCH] BTT: Change nd_btt_arena_is_valid() to verify UUID

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] BTT: Change nd_btt_arena_is_valid() to verify UUID
Date	2015-12-18 23:30 +0100
Message-ID	<qHbHb-3aG-5@gated-at.bofh.it> (permalink)
References	<qGPQl-61K-1@gated-at.bofh.it> <qGYJZ-3eE-19@gated-at.bofh.it> <qH4Z4-7jB-17@gated-at.bofh.it> <qH7tT-iI-3@gated-at.bofh.it> <qH8pY-U5-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 18, 2015 at 10:52 AM, Toshi Kani <toshi.kani@hpe.com> wrote:
> On Fri, 2015-12-18 at 09:54 -0800, Dan Williams wrote:
>> On Fri, Dec 18, 2015 at 7:15 AM, Toshi Kani <toshi.kani@hpe.com> wrote:
>> > On Fri, 2015-12-18 at 01:34 -0700, Vishal Verma wrote:
>> > > Also, I wonder if this problem is solved by using libndctl to manage
>> > > BTTs.
>> >
>> > I have not tested with libndctl yet, but I think our bind/unbind
>> > scripts do the same procedures.
>>
>> We loop through all combinations of sector size in our unit test.  If
>> you want to change the sector size the expectation is that the
>> namespace is destroyed and fully re-created, especially due to the
>> fact that changing sector size invalidates all data on the namespace.
>>
>> See: https://github.com/pmem/ndctl/blob/master/lib/test-libndctl.c
>
> The parent_uuid is not set on our NVDIMM-N systems.  I do not see 'uuid'
> file under sysfs 'namespaceX.X' per namespace_visible(), either.  This
> concept of creating/destroying a namespace is a bit foreign to us since
> we've never needed to do.  Can you elaborate how it's supposed to work for
> NVDIMM-N?
>

Ugh, yes.  An oversight on my part, let me give this some thought.
Whatever we decide, I want the libndctl api to be identical for the
two cases.

I expect the simplest option is to have
ndctl_namespace_disable_invalidate() destroy the btt-info block in the
NVDIMM-N case.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] BTT: Change nd_btt_arena_is_valid() to verify UUID Toshi Kani <toshi.kani@hpe.com> - 2015-12-18 00:10 +0100
  Re: [PATCH] BTT: Change nd_btt_arena_is_valid() to verify UUID Vishal Verma <vishal@kernel.org> - 2015-12-18 09:40 +0100
    Re: [PATCH] BTT: Change nd_btt_arena_is_valid() to verify UUID Toshi Kani <toshi.kani@hpe.com> - 2015-12-18 16:20 +0100
      Re: [PATCH] BTT: Change nd_btt_arena_is_valid() to verify UUID Dan Williams <dan.j.williams@intel.com> - 2015-12-18 19:00 +0100
        Re: [PATCH] BTT: Change nd_btt_arena_is_valid() to verify UUID Toshi Kani <toshi.kani@hpe.com> - 2015-12-18 20:00 +0100
          Re: [PATCH] BTT: Change nd_btt_arena_is_valid() to verify UUID Dan Williams <dan.j.williams@intel.com> - 2015-12-18 23:30 +0100

csiph-web