Re: [PATCH 3/3] arm: dts: bcm5301x: Add syscon based reboot in DT

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] arm: dts: bcm5301x: Add syscon based reboot in DT
Date	2015-12-18 22:50 +0100
Message-ID	<qHb4t-2GQ-9@gated-at.bofh.it> (permalink)
References	<qHaUN-2Dm-3@gated-at.bofh.it> <qHaUN-2Dm-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Friday 18 December 2015 16:37:56 Jon Mason wrote:
> +       cru: cru@1800c184 {
> +               compatible = "syscon";
> +               reg = <0x1800c184 0xc>;
> +       };

It's unusual for a device to start at such an odd address. Are you sure
it's not a larger device starting at 0x1800c000 or 0x18000000?

Also, please provide a more specific compatible string based on the
name of the device in the data sheet. The node name in contrast should
be more generic, e.g.

	cru: system-controller@1800c000 {
		compatible = "brcm,bcm53010-cru", "syscon";
		reg = <0x1800c000 0x400>; /* whatever the data sheet says */
	};

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] arm: dts: bcm5301x: Add syscon based reboot in DT Jon Mason <jonmason@broadcom.com> - 2015-12-18 22:40 +0100
  Re: [PATCH 3/3] arm: dts: bcm5301x: Add syscon based reboot in DT Arnd Bergmann <arnd@arndb.de> - 2015-12-18 22:50 +0100

csiph-web