Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1295173

Re: [PATCH] ARM: fix atags_to_fdt with stack-protector-strong

Show all headers | View raw

On Friday 18 December 2015 13:04:59 Kees Cook wrote:
> +ifeq ($(CONFIG_ARM_ATAG_DTB_COMPAT),y)
> +CFLAGS_atags_to_fdt.o := -fno-stack-protector
> +CFLAGS_fdt.o := -fno-stack-protector
> +CFLAGS_fdt_ro.o := -fno-stack-protector
> +CFLAGS_fdt_rw.o := -fno-stack-protector
> +CFLAGS_fdt_wip.o := -fno-stack-protector
> +endif

I'm pretty sure you don't need the ifeq there, you can simply define those
flags unconditionally.

You can't just add -fno-stack-protector unconditionally, because that
breaks building the kernel with toolchains that are older than stack-protector,
so this should be

CFLAGS_obj.o += $(call cc-option, -fno-stack-protector)

Other than that, the patch looks ok.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: fix atags_to_fdt with stack-protector-strong Kees Cook <keescook@chromium.org> - 2015-12-18 22:10 +0100
  Re: [PATCH] ARM: fix atags_to_fdt with stack-protector-strong Arnd Bergmann <arnd@arndb.de> - 2015-12-18 22:20 +0100
    Re: [PATCH] ARM: fix atags_to_fdt with stack-protector-strong Kees Cook <keescook@chromium.org> - 2015-12-18 22:30 +0100

csiph-web