Re: [PATCH] regulator: lp8788: constify regulator_ops structures

Path	csiph.com!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Milo Kim <milo.kim@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regulator: lp8788: constify regulator_ops structures
Date	Mon, 21 Dec 2015 00:30:01 +0100
Message-ID	<qHVAl-775-3@gated-at.bofh.it> (permalink)
References	<qHs5j-562-5@gated-at.bofh.it>
X-Original-To	Julia Lawall <Julia.Lawall@lip6.fr>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	65
Organization	linux.* mail to news gateway
X-Original-Cc	<kernel-janitors@vger.kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 21 Dec 2015 08:20:20 +0900
X-Original-Message-ID	<567737B4.40904@ti.com>
X-Original-References	<1450539802-22570-1-git-send-email-Julia.Lawall@lip6.fr>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1295708

Show key headers only | View raw

On 20/12/15 00:43, Julia Lawall wrote:
> The regulator_ops structures are never modified, so declare them as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Milo Kim <milo.kim@ti.com>

>
> ---
>   drivers/regulator/lp8788-buck.c |    4 ++--
>   drivers/regulator/lp8788-ldo.c  |    4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/lp8788-buck.c b/drivers/regulator/lp8788-buck.c
> index a97bed9..ec46290 100644
> --- a/drivers/regulator/lp8788-buck.c
> +++ b/drivers/regulator/lp8788-buck.c
> @@ -344,7 +344,7 @@ static unsigned int lp8788_buck_get_mode(struct regulator_dev *rdev)
>   				REGULATOR_MODE_FAST : REGULATOR_MODE_NORMAL;
>   }
>
> -static struct regulator_ops lp8788_buck12_ops = {
> +static const struct regulator_ops lp8788_buck12_ops = {
>   	.list_voltage = regulator_list_voltage_table,
>   	.map_voltage = regulator_map_voltage_ascend,
>   	.set_voltage_sel = lp8788_buck12_set_voltage_sel,
> @@ -357,7 +357,7 @@ static struct regulator_ops lp8788_buck12_ops = {
>   	.get_mode = lp8788_buck_get_mode,
>   };
>
> -static struct regulator_ops lp8788_buck34_ops = {
> +static const struct regulator_ops lp8788_buck34_ops = {
>   	.list_voltage = regulator_list_voltage_table,
>   	.map_voltage = regulator_map_voltage_ascend,
>   	.set_voltage_sel = regulator_set_voltage_sel_regmap,
> diff --git a/drivers/regulator/lp8788-ldo.c b/drivers/regulator/lp8788-ldo.c
> index 30e28b1..cbfd358 100644
> --- a/drivers/regulator/lp8788-ldo.c
> +++ b/drivers/regulator/lp8788-ldo.c
> @@ -170,7 +170,7 @@ static int lp8788_ldo_enable_time(struct regulator_dev *rdev)
>   	return ENABLE_TIME_USEC * val;
>   }
>
> -static struct regulator_ops lp8788_ldo_voltage_table_ops = {
> +static const struct regulator_ops lp8788_ldo_voltage_table_ops = {
>   	.list_voltage = regulator_list_voltage_table,
>   	.set_voltage_sel = regulator_set_voltage_sel_regmap,
>   	.get_voltage_sel = regulator_get_voltage_sel_regmap,
> @@ -180,7 +180,7 @@ static struct regulator_ops lp8788_ldo_voltage_table_ops = {
>   	.enable_time = lp8788_ldo_enable_time,
>   };
>
> -static struct regulator_ops lp8788_ldo_voltage_fixed_ops = {
> +static const struct regulator_ops lp8788_ldo_voltage_fixed_ops = {
>   	.list_voltage = regulator_list_voltage_linear,
>   	.enable = regulator_enable_regmap,
>   	.disable = regulator_disable_regmap,
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] regulator: lp8788: constify regulator_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2015-12-19 17:00 +0100
  Re: [PATCH] regulator: lp8788: constify regulator_ops structures Milo Kim <milo.kim@ti.com> - 2015-12-21 00:30 +0100
  Applied "regulator: lp8788: constify regulator_ops structures" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-12-23 01:20 +0100

csiph-web