[PATCH 2/4] clocksource/vt8500: Remove the 'loops' variable

Path	csiph.com!au2pb.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Roman Volkov <v1ron@mail.ru>
Newsgroups	linux.kernel
Subject	[PATCH 2/4] clocksource/vt8500: Remove the 'loops' variable
Date	Sun, 20 Dec 2015 23:40:01 +0100
Message-ID	<qHUNX-6At-3@gated-at.bofh.it> (permalink)
References	<qHUEi-6wx-9@gated-at.bofh.it>
X-Original-To	Tony Prisk <linux@prisktech.co.nz>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail2; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=FNI0nh92FF/wDp2cV8UU/Kj1uYLAeZ76AnaCmjFTOyI=; b=pINgXGKk8ymB3jvhtzcVGKkJOPUKwck813JlBwiuVR5ZKiXVnYErF7dFW2JhzxY9sSsyFh23JuvSsWgRVX92mBO2lTSC/vwDNTIWsQyDU/hd0vtKhBpA4t1uhw/M303OMfhXod4V7CXQqh8AAGNkZrw34IU3lhIKGK9ComtvE+k=;
X-Mailer	git-send-email 2.6.2
X-Mras	Ok
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	58
Organization	linux.* mail to news gateway
X-Original-Cc	Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Roman Volkov <rvolkov@v1ros.org>
X-Original-Date	Mon, 21 Dec 2015 01:28:10 +0300
X-Original-Message-ID	<1450650492-18996-3-git-send-email-v1ron@mail.ru>
X-Original-References	<1450650492-18996-1-git-send-email-v1ron@mail.ru>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1295701

Show key headers only | View raw

From: Roman Volkov <rvolkov@v1ros.org>

The purpose of the 'loops' variable is unclear. vt8500 hardware does not
require any protections, in case if these variables intended for preventing
infinite loops (identical PXA timer works perfectly without these ones). If
the loops count will not be calculated correctly, these variables will only
break the loop too early and introduce problems.

Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
---
 drivers/clocksource/vt8500_timer.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/clocksource/vt8500_timer.c b/drivers/clocksource/vt8500_timer.c
index 13ed892..f40ded8 100644
--- a/drivers/clocksource/vt8500_timer.c
+++ b/drivers/clocksource/vt8500_timer.c
@@ -48,8 +48,6 @@
 #define TIMER_COUNT_W_ACTIVE	(1 << 4)	/* not ready for write */
 #define TIMER_MATCH_W_ACTIVE	(1 << 0)	/* not ready for write */
 
-#define msecs_to_loops(t) (loops_per_jiffy / 1000 * HZ * t)
-
 #define timer_readl(addr)	readl_relaxed(regbase + addr)
 #define timer_writel(v, addr)	writel_relaxed(v, regbase + addr)
 
@@ -57,10 +55,10 @@ static void __iomem *regbase;
 
 static cycle_t vt8500_timer_read(struct clocksource *cs)
 {
-	int loops = msecs_to_loops(10);
 	timer_writel(3, TIMER_CTRL_VAL);
-	while ((timer_readl((TIMER_AS_VAL)) & TIMER_COUNT_R_ACTIVE) && --loops)
+	while (timer_readl(TIMER_AS_VAL) & TIMER_COUNT_R_ACTIVE)
 		cpu_relax();
+
 	return timer_readl(TIMER_COUNT_VAL);
 }
 
@@ -75,9 +73,8 @@ static struct clocksource clocksource = {
 static int vt8500_timer_set_next_event(unsigned long cycles,
 				    struct clock_event_device *evt)
 {
-	int loops = msecs_to_loops(10);
 	cycle_t alarm = clocksource.read(&clocksource) + cycles;
-	while ((timer_readl(TIMER_AS_VAL) & TIMER_MATCH_W_ACTIVE) && --loops)
+	while (timer_readl(TIMER_AS_VAL) & TIMER_MATCH_W_ACTIVE)
 		cpu_relax();
 	timer_writel((unsigned long)alarm, TIMER_MATCH_VAL);
 
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 2/4] clocksource/vt8500: Remove the 'loops' variable Roman Volkov <v1ron@mail.ru> - 2015-12-20 23:40 +0100

csiph-web