Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1295633

Re: [PATCH RESEND 1/1] serial: 8250_pci: Fix real serial port count for F81504/508/512

Show all headers | View raw

On Tue, Dec 15, 2015 at 4:56 AM, Peter Hung <hpeter@gmail.com> wrote:
> Andy Shevchenko 於 2015/12/13 上午 09:08 寫道:
>>
>> On Tue, Dec 1, 2015 at 8:54 AM, Peter Hung <hpeter@gmail.com> wrote:
>>> +/* The device is multi-function with UART & GPIO */
>>> +static u8 fintek_gpio_mapping[] = {2, 3, 8, 9, 10, 11};
>>
>>
>> Clearly you have bit combination here
>> Bit 1: 1
>> Bit 3: 1
>>
>> So, mask as 0x0a shall cover this IIAC.
>
>
> IMO, It maybe wrong. If we checked only with 0x0a mask,
> the 0x06 & 0x07 will be passed.

Ah, yes, it will be a bit more than just one check, something like:
(x & 0x0a) && (x & 0x0e != 6)


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH RESEND 1/1] serial: 8250_pci: Fix real serial port count  for F81504/508/512 Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-13 02:10 +0100
  Re: [PATCH RESEND 1/1] serial: 8250_pci: Fix real serial port count  for F81504/508/512 Peter Hung <hpeter@gmail.com> - 2015-12-15 04:00 +0100
    Re: [PATCH RESEND 1/1] serial: 8250_pci: Fix real serial port count  for F81504/508/512 Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-20 18:20 +0100
  Re: [PATCH RESEND 1/1] serial: 8250_pci: Fix real serial port count  for F81504/508/512 Peter Hung <hpeter@gmail.com> - 2015-12-28 04:50 +0100

csiph-web