firmware_class warnings on resume

From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	firmware_class warnings on resume
Date	2015-12-20 13:30 +0100
Message-ID	<qHLhD-vI-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

I hit this warning fairly frequently when resuming 4.4-rc5:

        ret = usermodehelper_read_trylock();
        if (WARN_ON(ret)) {
            dev_err(device, "firmware: %s will not be loaded\n",
                name);
            goto out;
        }

It seems like it could be improved in two ways fairly easily:

1. Shouldn't firmware_class try the direct load before trying to get
the usermodehelper lock?

2. Why is the !NOWAIT case doing a trylock?  That seems wrong.

--Andy

-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

firmware_class warnings on resume Andy Lutomirski <luto@amacapital.net> - 2015-12-20 13:30 +0100
  Re: firmware_class warnings on resume Laura Abbott <labbott@redhat.com> - 2015-12-21 19:00 +0100
    Re: firmware_class warnings on resume Andy Lutomirski <luto@amacapital.net> - 2015-12-21 23:50 +0100

csiph-web