Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1295563

Re: [PATCH] iio: add ad5761 DAC driver

Show all headers | View raw

Hello Peter:


Thanks for your review! I agree on all your points but one:

On Sat, Dec 19, 2015 at 6:06 PM, Peter Meerwald-Stadler
<pmeerw@pmeerw.net> wrote:
>> +     .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),   \
>> +     .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |  \
>> +             BIT(IIO_CHAN_INFO_OFFSET),              \
>> +     .scan_type = {                                  \
>
> the driver does not support buffered mode, not sure if scan_type should be
> used to store the number of bits; I think it would be cleaner to put this
> in chip_info


Although I understand your point, must of the other dac drivers are
doing the same and in my humble opinion is very elegant.



Best regards!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iio: add ad5761 DAC driver Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2015-12-16 14:30 +0100
  Re: [PATCH] iio: add ad5761 DAC driver Jonathan Cameron <jic23@kernel.org> - 2015-12-19 17:40 +0100
    Re: [PATCH] iio: add ad5761 DAC driver Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2015-12-20 12:30 +0100
      Re: [PATCH] iio: add ad5761 DAC driver Jonathan Cameron <jic23@kernel.org> - 2015-12-22 19:20 +0100
  Re: [PATCH] iio: add ad5761 DAC driver Peter Meerwald-Stadler <pmeerw@pmeerw.net> - 2015-12-19 18:10 +0100
    Re: [PATCH] iio: add ad5761 DAC driver Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2015-12-20 12:30 +0100

csiph-web