Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1295110

Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various paths

Show all headers | View raw

On 12/18/2015 08:11 PM, Brian Norris wrote:
> On Mon, Dec 14, 2015 at 11:49:32AM +0200, Peter Ujfalusi wrote:
>> We have 4 functions containing almost identical DMA setup code. Create one
>> function which can set up the DMA for both read and write and use this in
>> place for the setup code in the driver.
>> The new function will use wait_for_completion_timeout() and it will figure
>> out the best data_type to be used for the transfer instead of hardwiring
>> 32 or 16 bit data.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> 
> Does anyone use this driver? I've seen practically zero activity on the
> entire OneNAND codebase in the last few years, and I presumed it was
> essentially dead.
> 
> If it's not dead, I'd like to know some contingency of people who are
> willing to actually maintain (or at least review) this stuff.
> 
> Kyungmin, are you still out there? Or Tony, do you know of any users for
> this?
> 
> Peter, are you actually using this, or are you just refactoring for the
> fun of it?

Not really for fun, but I want to get rid of all legacy/direct sDMA use so at
the end we will have omap_start_dma() visible in two files:
arch/arm/plat-omap/dma.c
drivers/dma/omap-dma.c

from there it will be possible to get rid of the plat-omap code. This onenand
driver was the first in the 'git grep omap_start_dma' result ;)

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: onenand: omap2: Simplify the DMA setup for various paths Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-12-14 11:00 +0100
  Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various  paths Brian Norris <computersforpeace@gmail.com> - 2015-12-18 19:20 +0100
    Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various  paths Tony Lindgren <tony@atomide.com> - 2015-12-18 19:40 +0100
      Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various  paths Aaro Koskinen <aaro.koskinen@iki.fi> - 2015-12-19 14:40 +0100
        Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various  paths Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-12-21 09:20 +0100
    Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various  paths Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-12-18 20:50 +0100
      Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various  paths Brian Norris <computersforpeace@gmail.com> - 2015-12-18 23:40 +0100

csiph-web