Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1295070
| From | Alexander Shishkin <alexander.shishkin@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/7] perf: Generalize task_function_call()ers |
| Date | 2015-12-18 18:50 +0100 |
| Message-ID | <qH7ke-ff-13@gated-at.bofh.it> (permalink) |
| References | (6 earlier) <qGHJ8-Ah-17@gated-at.bofh.it> <qGIlQ-154-27@gated-at.bofh.it> <qGZd0-3FA-31@gated-at.bofh.it> <qH4Po-7gd-3@gated-at.bofh.it> <qH6oa-86R-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Peter Zijlstra <peterz@infradead.org> writes: > On Fri, Dec 18, 2015 at 05:07:34PM +0200, Alexander Shishkin wrote: >> Peter Zijlstra <peterz@infradead.org> writes: >> >> > @@ -2774,9 +2696,6 @@ static void perf_event_context_sched_in( >> > */ >> > cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE); >> > >> > - if (ctx->nr_events) >> > - cpuctx->task_ctx = ctx; >> > - >> > perf_event_sched_in(cpuctx, cpuctx->task_ctx, task); >> >> This then should probably become >> >> perf_event_sched_in(cpuctx, ctx, task); >> >> otherwise task contexts just don't get scheduled any more. > > Very good, thanks! > > Running with that triggers another WARN, I'll have a look at that later > tonight. Hmm, is it the one from event_function() where a task context is scheduled, but is inactive and/or doesn't have events? I think there's also more fun to be had there now that you've started digging it up, I'll also poke at it more later today. Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 2/7] perf: Generalize task_function_call()ers Peter Zijlstra <peterz@infradead.org> - 2015-12-17 14:50 +0100
Re: [PATCH 2/7] perf: Generalize task_function_call()ers Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-12-17 15:30 +0100
Re: [PATCH 2/7] perf: Generalize task_function_call()ers Peter Zijlstra <peterz@infradead.org> - 2015-12-17 16:10 +0100
Re: [PATCH 2/7] perf: Generalize task_function_call()ers Peter Zijlstra <peterz@infradead.org> - 2015-12-18 10:10 +0100
Re: [PATCH 2/7] perf: Generalize task_function_call()ers Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-12-18 16:10 +0100
Re: [PATCH 2/7] perf: Generalize task_function_call()ers Peter Zijlstra <peterz@infradead.org> - 2015-12-18 17:50 +0100
Re: [PATCH 2/7] perf: Generalize task_function_call()ers Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-12-18 18:50 +0100
Re: [PATCH 2/7] perf: Generalize task_function_call()ers Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-12-21 15:50 +0100
csiph-web