Re: [PATCH v2] mtd: omap_elm: print interrupt resource using %pr

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mtd: omap_elm: print interrupt resource using %pr
Date	Fri, 18 Dec 2015 19:30:02 +0100
Message-ID	<qH7WW-Im-7@gated-at.bofh.it> (permalink)
References	<qH36X-682-13@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ga7ANcAMwcfiz46EQLydp2mzXFAavMVdZk7kMHAe/1U=; b=YkWX/81oYwEHLgoI525W4u9fF4TaOycCN8FeJiUy2hmNd2FtmtfpLhveBjeRuNK+x9 VMwRIPeTcaU6nZGAw/WNBfLZdEgoM1SP6ZJdJhZhsuSj3+x0eoHcTAR60NfykQuvONfb /rIfkRxm1RD+zbC3RYKudKvfqx3Q7nSLakwuJFkzj8+VxoelO+i9Vou37RwgWPX953En 64vxwcmuiRsgcgskkGnrTNdjFu/sT9zPOH0CyQOLGMZvlgHjDWlxosjYV7Cto++39M91 yFLYKC0NX8eMD5u+qXTlkZ9fvrHqC8/i0I2t0vruQyVGg5HH9ic2Evz42s3JgkKgR6e4 9aRw==
X-Received	by 10.66.102.37 with SMTP id fl5mr7384223pab.24.1450463080116; Fri, 18 Dec 2015 10:24:40 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	Tony Lindgren <tony@atomide.com>, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>, linux-arm-kernel@lists.infradead.org, Roger Quadros <rogerq@ti.com>
X-Original-Date	Fri, 18 Dec 2015 10:24:37 -0800
X-Original-Message-ID	<20151218182437.GM10460@google.com>
X-Original-References	<2327550.1yLrRnIh7I@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1295086

Show key headers only | View raw

On Fri, Dec 18, 2015 at 02:15:17PM +0100, Arnd Bergmann wrote:
> When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide
> and we get a warning about an incorrect format string for printing
> the interrupt number in elm_probe:
> 
> drivers/mtd/nand/omap_elm.c: In function 'elm_probe':
> drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
> 
> This patch avoids the type mismatch by printing the interrupt as
> a resource using the %pr format string.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: pass correct pointer
> 
> diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c
> index 235ec7992b4c..a3f32f939cc1 100644
> --- a/drivers/mtd/nand/omap_elm.c
> +++ b/drivers/mtd/nand/omap_elm.c
> @@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev)
>  	ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0,
>  			pdev->name, info);
>  	if (ret) {
> -		dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start);
> +		dev_err(&pdev->dev, "failure requesting %pr\n", irq);

FWIW, the printk documentation isn't very specific about the formatting
for %pr. After drilling down to resource_string() in lib/vsprintf.c, it
looks like there is special case handling for various resrouce types,
even though the documentation only shows IORESOURCE_MEM types.

Applied to l2-mtd.git.

>  		return ret;
>  	}
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] mtd: omap_elm: print interrupt resource using %pr Arnd Bergmann <arnd@arndb.de> - 2015-12-18 14:20 +0100
  Re: [PATCH v2] mtd: omap_elm: print interrupt resource using %pr Brian Norris <computersforpeace@gmail.com> - 2015-12-18 19:30 +0100

csiph-web