Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1295080

Re: [PATCH] ila: add NETFILTER dependency

Show all headers | View raw

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Fri, Dec 18, 2015 at 03:37:37PM +0100, Arnd Bergmann wrote:
> > The recently added generic ILA translation facility fails to
> > build when CONFIG_NETFILTER is disabled:
> > 
> > net/ipv6/ila/ila_xlat.c:229:20: warning: 'struct nf_hook_state' declared inside parameter list
> > net/ipv6/ila/ila_xlat.c:235:27: error: array type has incomplete element type 'struct nf_hook_ops'
> >  static struct nf_hook_ops ila_nf_hook_ops[] __read_mostly = {
> > 
> > This adds an explicit Kconfig dependency to avoid that case.
> 
> I'm afraid this extra Kconfig dependency that Arnd adds to fix this is
> a symptom that there is something that doesn't belong there.
> 
> I overlook this new hook on priority -1, how does this integrate into
> our infrastructure?

Looks problematic since address changes post ipv6 dnat translations,
its certainly unexpected for nft since we have magic address mangling
after -2 and 0 priroized tables...

However ... how is ILA supposed to work?

ila_xlat_outgoing has no callers, so it appears we only do this
stateless nat on ingress...?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ila: add NETFILTER dependency Arnd Bergmann <arnd@arndb.de> - 2015-12-18 15:40 +0100
  Re: [PATCH] ila: add NETFILTER dependency Pablo Neira Ayuso <pablo@netfilter.org> - 2015-12-18 18:30 +0100
    Re: [PATCH] ila: add NETFILTER dependency Florian Westphal <fw@strlen.de> - 2015-12-18 19:10 +0100
      Re: [PATCH] ila: add NETFILTER dependency Pablo Neira Ayuso <pablo@netfilter.org> - 2015-12-18 21:40 +0100
  Re: [PATCH] ila: add NETFILTER dependency David Miller <davem@davemloft.net> - 2015-12-18 20:20 +0100

csiph-web