Re: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel devices

From	James Bottomley <James.Bottomley@HansenPartnership.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel devices
Date	2015-12-18 18:20 +0100
Message-ID	<qH6Rb-5l-5@gated-at.bofh.it> (permalink)
References	<qFk2e-3De-7@gated-at.bofh.it> <qFk2e-3De-9@gated-at.bofh.it> <qFk2e-3De-5@gated-at.bofh.it> <qGYTD-3jm-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2015-12-18 at 09:49 +0100, Hannes Reinecke wrote:
> What I would like to see is a clear separation here:
> - Disable FC disk handling if FC attributes are not configured
> - Add a module parameter allowing to disable FC attributes even if 
> they are compiled in. Remember: this is a virtualized guest, and 
> people might want so save kernel memory wherever they can. So always 
> attaching to the fc transport template will make them very unhappy.
> Alternatively you could split out FC device handling into a separate 
> driver, but seeing the diff that's probably overkill.

I don't quite see how this can be a module parameter: the
fc_transport_class is pulled in by symbol references.  They won't go
away whether a module parameter is zero or one.  The only way to get
the module not to link with a transport class is to have it not use the
symbols at compile time (either because they're surrounded by an #ifdef
or with an if() which the compiler evaluates at compile time to zero). 
 In userspace you get around this with introspection and dlopen, but I
don't think we have that functionality in the kernel.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel devices "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-13 20:00 +0100
  Re: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel  devices Hannes Reinecke <hare@suse.de> - 2015-12-18 09:50 +0100
    RE: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel  devices KY Srinivasan <kys@microsoft.com> - 2015-12-18 18:20 +0100
    Re: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel  devices James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-12-18 18:20 +0100
      RE: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel  devices KY Srinivasan <kys@microsoft.com> - 2015-12-21 17:20 +0100

csiph-web