Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1294659

[PATCH] tools build: Output more data during feature detection

From Wang Nan <wangnan0@huawei.com>
Newsgroups linux.kernel
Subject [PATCH] tools build: Output more data during feature detection
Date 2015-12-18 12:00 +0100
Message-ID <qH0Vs-4xe-5@gated-at.bofh.it> (permalink)
References <qGZ3k-3mL-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Even with current '.make.output' finding the root cause for missing
feature is not enough. This patch adds extra information to
.make.output. It also creates a .make.makeoutput to collect output of
'make'.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Jiri Olsa <jolsa@kernel.org>
---
 tools/build/Makefile.feature | 4 ++--
 tools/build/feature/Makefile | 7 ++++++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
index 6c0519d..84927df 100644
--- a/tools/build/Makefile.feature
+++ b/tools/build/Makefile.feature
@@ -1,13 +1,13 @@
 feature_dir := $(srctree)/tools/build/feature
 
 ifneq ($(OUTPUT),)
-  OUTPUT_FEATURES = $(OUTPUT)feature/
+  OUTPUT_FEATURES = $(OUTPUT)feature$(FEATURE_USER)/
   $(shell mkdir -p $(OUTPUT_FEATURES))
 endif
 
 feature_check = $(eval $(feature_check_code))
 define feature_check_code
-  feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS) $(FEATURE_CHECK_CFLAGS-$(1))" LDFLAGS="$(LDFLAGS) $(FEATURE_CHECK_LDFLAGS-$(1))" -C $(feature_dir) $(OUTPUT_FEATURES)test-$1.bin >/dev/null 2>/dev/null && echo 1 || echo 0)
+  feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS) $(FEATURE_CHECK_CFLAGS-$(1))" LDFLAGS="$(LDFLAGS) $(FEATURE_CHECK_LDFLAGS-$(1))" -C $(feature_dir) $(OUTPUT_FEATURES)test-$1.bin >$(OUTPUT_FEATURES)test-$1.make.makeoutput 2>&1 && echo 1 || echo 0)
 endef
 
 feature_set = $(eval $(feature_set_code))
diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
index bf8f035..842973a 100644
--- a/tools/build/feature/Makefile
+++ b/tools/build/feature/Makefile
@@ -45,7 +45,12 @@ PKG_CONFIG := $(CROSS_COMPILE)pkg-config
 all: $(FILES)
 
 __BUILD = $(CC) $(CFLAGS) -Wall -Werror -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS)
-  BUILD = $(__BUILD) > $(@:.bin=.make.output) 2>&1
+  BUILD = echo PWD=$(shell pwd) > $(@:.bin=.make.output); \
+	  echo PATH=$$PATH >> $(@:.bin=.make.output); \
+	  echo CFLAGS=$$CFLAGS >> $(@:.bin=.make.output); \
+	  echo LDFLAGS=$$LDFLAGS >> $(@:.bin=.make.output); \
+	  echo '$(__BUILD)' >> $(@:.bin=.make.output) ; \
+	  $(__BUILD) >> $(@:.bin=.make.output) 2>&1
 
 ###############################
 
-- 
1.8.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
  [PATCH 01/10] bpf samples: bpf: Fix tracex5_kern.c compiling error Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
  [PATCH 05/10] bpf tools: Support load different type of programs Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
  [PATCH 03/10] bpf tools: Add const decoretor to 'license' and 'insns' for bpf_load_program() Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
  [PATCH 02/10] bpf tools: Define LD and RM in Makefile for 'make -R' Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
  [PATCH 06/10] bpf tools: Support new map operations Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
    Re: [PATCH 06/10] bpf tools: Support new map operations "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-17 07:10 +0100
    [PATCH v2 06/10] bpf tools: Support new map operations Wang Nan <wangnan0@huawei.com> - 2015-12-17 07:20 +0100
  [PATCH 07/10] bpf tools: Support BPF_OBJ_PIN and BPF_OBJ_GET Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:30 +0100
  [PATCH 09/10] bpf samples: Uses libbpf in tools/lib to deal with BPF operations Wang Nan <wangnan0@huawei.com> - 2015-12-17 06:40 +0100
  Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-17 07:40 +0100
    Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-17 08:00 +0100
      Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-17 08:10 +0100
        Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-17 09:30 +0100
          Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-17 11:20 +0100
            Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-17 14:50 +0100
              Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-18 04:10 +0100
                Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-18 10:00 +0100
                [PATCH] tools build: Output more data during feature detection Wang Nan <wangnan0@huawei.com> - 2015-12-18 12:00 +0100
                Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-18 12:10 +0100
                Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-18 14:00 +0100
                Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations pi3orama <pi3orama@163.com> - 2015-12-18 15:20 +0100
                Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF  operations Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-12-18 15:30 +0100

csiph-web