Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1293444
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Eric Anholt <eric@anholt.net> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] PM / sleep: define inline functions |
| Date | Thu, 17 Dec 2015 01:50:03 +0100 |
| Message-ID | <qGuVB-Ae-39@gated-at.bofh.it> (permalink) |
| References | <qGiKK-1es-23@gated-at.bofh.it> |
| X-Original-To | Sudip Mukherjee <sudipm.mukherjee@gmail.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com> |
| User-Agent | Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) |
| MIME-Version | 1.0 |
| Content-Type | multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 62 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
| X-Original-Date | Wed, 16 Dec 2015 16:41:37 -0800 |
| X-Original-Message-ID | <87wpsdrjni.fsf@eliezer.anholt.net> |
| X-Original-References | <1450266099-4352-1-git-send-email-sudipm.mukherjee@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1293444 |
Show key headers only | View raw
[Multipart message — attachments visible in raw view] - view raw
Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes:
> If CONFIG_PM_SLEEP is not defined then the functions are defined as
> NULL. And as a result we are getting build failure with
> alpha allmodconfig with the error:
>
> drivers/gpu/drm/vc4/vc4_v3d.c: In function 'vc4_v3d_set_power':
> include/linux/stddef.h:7:14: error: called object is not a function or function pointer
> #define NULL ((void *)0)
> ^
> include/linux/pm.h:776:30: note: in expansion of macro 'NULL'
> #define pm_generic_poweroff NULL
> ^
> drivers/gpu/drm/vc4/vc4_v3d.c:157:10: note: in expansion of macro 'pm_generic_poweroff'
> return pm_generic_poweroff(&vc4->v3d->pdev->dev);
> ^
> include/linux/stddef.h:7:14: error: called object is not a function or function pointer
> #define NULL ((void *)0)
> ^
> include/linux/pm.h:764:28: note: in expansion of macro 'NULL'
> #define pm_generic_resume NULL
> ^
> drivers/gpu/drm/vc4/vc4_v3d.c:159:10: note: in expansion of macro 'pm_generic_resume'
> return pm_generic_resume(&vc4->v3d->pdev->dev);
> ^
>
> Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.")
> Cc: Eric Anholt <eric@anholt.net>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
I'm happy with this solution, and would also be willing to just depend
on the config option as well. Whatever people prefer.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] PM / sleep: define inline functions Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-16 12:50 +0100
Re: [PATCH] PM / sleep: define inline functions Eric Anholt <eric@anholt.net> - 2015-12-17 01:50 +0100
Re: [PATCH] PM / sleep: define inline functions "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-17 02:20 +0100
Re: [PATCH] PM / sleep: define inline functions Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-17 09:00 +0100
Re: [PATCH] PM / sleep: define inline functions Eric Anholt <eric@anholt.net> - 2015-12-17 20:20 +0100
csiph-web