Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1293284

[PATCH] clk: gpio: fix memory leak in of_gpio_clk_setup()

Show all headers | View raw

Reported by Coverity.

Fixes: f66541ba02d5 ("clk: gpio: Get parent clk names in of_gpio_clk_setup()")
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: Sergej Sawazki <ce3a@gmx.de>
Cc: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/clk/clk-gpio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
index 335322dc403f..c1baa89cbf91 100644
--- a/drivers/clk/clk-gpio.c
+++ b/drivers/clk/clk-gpio.c
@@ -294,8 +294,10 @@ static void __init of_gpio_clk_setup(struct device_node *node,
 	num_parents = of_clk_get_parent_count(node);
 
 	parent_names = kcalloc(num_parents, sizeof(char *), GFP_KERNEL);
-	if (!parent_names)
+	if (!parent_names) {
+		kfree(data);
 		return;
+	}
 
 	for (i = 0; i < num_parents; i++)
 		parent_names[i] = of_clk_get_parent_name(node, i);
-- 
2.6.0.rc2.230.g3dd15c0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: gpio: fix memory leak in of_gpio_clk_setup() Brian Norris <computersforpeace@gmail.com> - 2015-12-16 19:30 +0100
  [PATCH] clk: gpio: handle error codes for of_clk_get_parent_count() Brian Norris <computersforpeace@gmail.com> - 2015-12-16 19:40 +0100
    Re: [PATCH] clk: gpio: handle error codes for of_clk_get_parent_count() Michael Turquette <mturquette@baylibre.com> - 2016-01-01 07:00 +0100
  Re: [PATCH] clk: gpio: fix memory leak in of_gpio_clk_setup() Michael Turquette <mturquette@baylibre.com> - 2016-01-01 07:00 +0100

csiph-web