Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1293259

Re: [PATCH RESEND] infiniband:core:Add needed error path in cm_init_av_by_path

Show all headers | View raw

On Wed, Dec 16, 2015 at 11:26:39AM +0100, Michael Wang wrote:
> 
> On 12/15/2015 06:30 PM, Jason Gunthorpe wrote:
> > On Tue, Dec 15, 2015 at 05:38:34PM +0100, Michael Wang wrote:
> >> The hop_limit is only suggest that the package allowed to be
> >> routed, not have to, correct?
> > 
> > If the hop limit is >= 2 (?) then the GRH is mandatory. The
> > SM will return this information in the PathRecord if it determines a
> > GRH is required. The whole stack follows this protocol.
> > 
> > The GRH is optional for in-subnet communications.
> 
> Thanks for the explain :-)
> 
> I've rechecked the ib_init_ah_from_path() again, and found it
> still set IB_AH_GRH when the GID cache missing, but with:

How do you mean?

                ah_attr->ah_flags = IB_AH_GRH;
                ah_attr->grh.dgid = rec->dgid;

                ret = ib_find_cached_gid(device, &rec->sgid, ndev, &port_num,
                                         &gid_index);
                if (ret) {
                        if (ndev)
                                dev_put(ndev);
                        return ret;
                }

If find_cached_gid fails then ib_init_ah_from_path also fails.

Is there a case where ib_find_cached_gid can succeed but not return
good data?

I agree it would read nicer if the ah_flags and gr.dgid was moved
after the ib_find_cached_gid

> BTW, cma_sidr_rep_handler() also call ib_init_ah_from_path() with out
> a check on return.

That sounds like a problem.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH RESEND] infiniband:core:Add needed error path in  cm_init_av_by_path Michael Wang <yun.wang@profitbricks.com> - 2015-12-15 17:40 +0100
  Re: [PATCH RESEND] infiniband:core:Add needed error path in  cm_init_av_by_path Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-15 18:40 +0100
    Re: [PATCH RESEND] infiniband:core:Add needed error path in cm_init_av_by_path "ira.weiny" <ira.weiny@intel.com> - 2015-12-16 08:00 +0100
    Re: [PATCH RESEND] infiniband:core:Add needed error path in  cm_init_av_by_path Michael Wang <yun.wang@profitbricks.com> - 2015-12-16 11:30 +0100
      Re: [PATCH RESEND] infiniband:core:Add needed error path in  cm_init_av_by_path Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-16 19:20 +0100
        Re: [PATCH RESEND] infiniband:core:Add needed error path in  cm_init_av_by_path Michael Wang <yun.wang@profitbricks.com> - 2015-12-17 09:50 +0100

csiph-web