[PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in clear_soft_dirty_pmd()

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in clear_soft_dirty_pmd()
Date	Wed, 16 Dec 2015 18:30:01 +0100
Message-ID	<qGo3L-4HH-7@gated-at.bofh.it> (permalink)
X-Original-To	Andrew Morton <akpm@linux-foundation.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.18 (2008-05-17)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.22
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, Cyrill Gorcunov <gorcunov@gmail.com>, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 16 Dec 2015 18:26:32 +0100
X-Original-Message-ID	<20151216172632.GA7589@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1293136

Show key headers only | View raw

clear_soft_dirty_pmd() is called by clear_refs_write(CLEAR_REFS_SOFT_DIRTY),
VM_SOFTDIRTY was already cleared before walk_page_range().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 fs/proc/task_mmu.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 187b3b5..1a02b15 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -817,9 +817,6 @@ static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma,
 	pmd = pmd_wrprotect(pmd);
 	pmd = pmd_clear_soft_dirty(pmd);
 
-	if (vma->vm_flags & VM_SOFTDIRTY)
-		vma->vm_flags &= ~VM_SOFTDIRTY;
-
 	set_pmd_at(vma->vm_mm, addr, pmdp, pmd);
 }
 #else
-- 
1.5.5.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in  clear_soft_dirty_pmd() Oleg Nesterov <oleg@redhat.com> - 2015-12-16 18:30 +0100
  Re: [PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY  in clear_soft_dirty_pmd() "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-12-16 18:50 +0100
  Re: [PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY  in clear_soft_dirty_pmd() Cyrill Gorcunov <gorcunov@gmail.com> - 2015-12-16 19:00 +0100
  Re: [PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY  in clear_soft_dirty_pmd() David Rientjes <rientjes@google.com> - 2015-12-22 23:10 +0100

csiph-web