Re: [PATCH 1/2] ASoC: atmel-pdmic: add the Pulse Density Modulation Interface Controller

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] ASoC: atmel-pdmic: add the Pulse Density Modulation Interface Controller
Date	2015-12-16 13:30 +0100
Message-ID	<qGjns-1I6-17@gated-at.bofh.it> (permalink)
References	<qFwG6-3zr-7@gated-at.bofh.it> <qFwG6-3zr-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Dec 14, 2015 at 04:15:39PM +0800, Songjun Wu wrote:

> Add driver for the Pulse Density Modulation Interface
> Controller. It comes with digitallly controlled gain,
> a High-Pass and a SINCC filter.

This looks basically OK but there's a *lot* of weird coding style issues
in here.  It's really all that, nothing too serious that I noticed -
I've pointed out some of the patterns below not every individual issue.

> +	for (i = 0; i < ARRAY_SIZE(mic_gain_table); i++) {
> +		if ((mic_gain_table[i].dgain == dgain_val)
> +		&& (mic_gain_table[i].scale == scale_val))
> +			ucontrol->value.integer.value[0] = i;
> +	}

This indentation is really weird, why is the && aligned with the if?

> +	snd_soc_update_bits(codec, PDMIC_DSPR1,
> +		PDMIC_DSPR1_OFFSET_MASK,
> +		(u32)(dd->pdata->mic_offset << PDMIC_DSPR1_OFFSET_SHIFT));

These are weird too, I'd expect the second line to be part of the first.

> +static struct regmap *atmel_pdmic_codec_get_remap(struct device *dev)
> +{
> +	return dev_get_regmap(dev, NULL);
> +}

This is (or should be) the default in the core.

> +	if ((fs < rate_min) || (fs > rate_max)) {
> +		dev_err(codec->dev,
> +		"sample rate is %dHz, min rate is %dHz, max rate is %dHz\n",
> +		fs, rate_min, rate_max);

This too, alignment after the (.

> +	if (bits == 16)
> +		dspr0_val = (PDMIC_DSPR0_SIZE_16_BITS
> +				<< PDMIC_DSPR0_SIZE_SHIFT);
> +	else if (bits == 32)
> +		dspr0_val = (PDMIC_DSPR0_SIZE_32_BITS
> +				<< PDMIC_DSPR0_SIZE_SHIFT);
> +	else
> +		return -EINVAL;

This looks like it should be a switch statement.

Thread

[PATCH 0/2] ASoC: atmel-pdmic: add driver for Atmel PDMIC Songjun Wu <songjun.wu@atmel.com> - 2015-12-14 09:30 +0100
  [PATCH 2/2] ASoC: atmel-pdmic: DT binding for PDMIC driver Songjun Wu <songjun.wu@atmel.com> - 2015-12-14 09:30 +0100
  [PATCH 1/2] ASoC: atmel-pdmic: add the Pulse Density Modulation Interface Controller Songjun Wu <songjun.wu@atmel.com> - 2015-12-14 09:30 +0100
    Re: [PATCH 1/2] ASoC: atmel-pdmic: add the Pulse Density Modulation  Interface Controller Mark Brown <broonie@kernel.org> - 2015-12-16 13:30 +0100
      Re: [PATCH 1/2] ASoC: atmel-pdmic: add the Pulse Density Modulation  Interface Controller "Wu, Songjun" <songjun.wu@atmel.com> - 2015-12-17 03:50 +0100

csiph-web