Re: [PATCH 6/9] rmap: support file THP

From	"Kirill A. Shutemov" <kirill@shutemov.name>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/9] rmap: support file THP
Date	2015-12-16 13:10 +0100
Message-ID	<qGj45-1Aw-1@gated-at.bofh.it> (permalink)
References	<qwkkN-1pG-3@gated-at.bofh.it> <qwkkO-1pG-21@gated-at.bofh.it> <qB0bM-6as-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 01, 2015 at 12:56:13PM -0800, Dave Hansen wrote:
> On 11/18/2015 03:25 PM, Kirill A. Shutemov wrote:
> > -void page_add_file_rmap(struct page *page)
> > +void page_add_file_rmap(struct page *page, bool compound)
> 
> I take it we have to pass 'compound' in explicitly because
> PageCompound() could be true, but we don't want to do a compound
> mapping.  This is true for those weirdo sound driver allocations and a
> few other ones, right?

Right. Also more common case will be PTE-mapped THPs as we have now for
anon-THP.

Basically, we mirror what was done for anon rmap interface.

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 6/9] rmap: support file THP "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-12-16 13:10 +0100

csiph-web