Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1292855

Re: [PATCH v5 2/3] arm64: dts: mt8173: Add thermal zone node.

Show all headers | View raw

On Wed, 2015-12-16 at 16:34 +0800, Daniel Kurtz wrote:
> On Wed, Dec 16, 2015 at 11:59 AM, Dawei Chien <dawei.chien@mediatek.com> wrote:
> >
> > This adds thermal zone node to Mediatek MT8173 dtsi file.
> >
> > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
> > ---
> > This patch is base on patchset:
> > https://lkml.org/lkml/2015/11/30/239
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8173.dtsi |   43 ++++++++++++++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index fda805d..4114cee 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -188,6 +188,49 @@
> >                 clock-output-names = "cpum_ck";
> >         };
> >
> > +       thermal-zones {
> > +               cpu_thermal: cpu_thermal {
> > +                       polling-delay-passive = <1000>; /* milliseconds */
> > +                       polling-delay = <1000>; /* milliseconds */
> > +
> > +                       thermal-sensors = <&thermal 0>;
> 
> This should be <&thermal> with the MTK temp sensor node in
> https://lkml.org/lkml/2015/11/30/239 patch series.
> 
> -Dan

Hi Dan,
Sascha's thermal driver V12 only register sensor id as 0, so we need to
register sensor id as 0 to device tree as well.

Either <&thermal 0> or <&thermal>, sensor id should be 0 for two cases.
I try this two case, function all work fine for two cases. May I have
any misunderstand? Please kindly give your comment.
I will re-send this patch again once you tell me the reason, thank you.

BR,
Dawei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 2/3] arm64: dts: mt8173: Add thermal zone node. Dawei Chien <dawei.chien@mediatek.com> - 2015-12-16 05:00 +0100
  Re: [PATCH v5 2/3] arm64: dts: mt8173: Add thermal zone node. Daniel Kurtz <djkurtz@chromium.org> - 2015-12-16 09:40 +0100
    Re: [PATCH v5 2/3] arm64: dts: mt8173: Add thermal zone node. dawei chien <dawei.chien@mediatek.com> - 2015-12-16 11:10 +0100
      Re: [PATCH v5 2/3] arm64: dts: mt8173: Add thermal zone node. Daniel Kurtz <djkurtz@chromium.org> - 2015-12-16 12:30 +0100
        Re: [PATCH v5 2/3] arm64: dts: mt8173: Add thermal zone node. dawei chien <dawei.chien@mediatek.com> - 2015-12-16 13:20 +0100

csiph-web