Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1292815

Re: [PATCH/RFC 01/10] iommu/ipmmu-vmsa: Introduce features, break out alias

Show all headers | View raw

Hi Magnus,

On Tue, Dec 15, 2015 at 2:05 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Introduce struct ipmmu_features to track various hardware
> and software implementation changes inside the driver for
> various kinds of IPMMU hardware. Add use_ns_alias_offset
> as a first example of a feature to control if the secure
> register bank offset should be used or not.
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
>
>  drivers/iommu/ipmmu-vmsa.c |   34 ++++++++++++++++++++++++++++------
>  1 file changed, 28 insertions(+), 6 deletions(-)
>
> --- 0009/drivers/iommu/ipmmu-vmsa.c
> +++ work/drivers/iommu/ipmmu-vmsa.c     2015-12-15 13:41:22.600513000 +0900
> @@ -31,6 +31,10 @@
>
>  #define IPMMU_CTX_MAX 1
>
> +struct ipmmu_features {
> +       bool use_ns_alias_offset;
> +};

Given you're adding more than 4 features in this series, you may want to
consider using an unsigned int bitfield instead.

That way you could also store it directly in of_device_id.data, if you want.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH/RFC 01/10] iommu/ipmmu-vmsa: Introduce features, break out alias Magnus Damm <magnus.damm@gmail.com> - 2015-12-15 14:10 +0100
  Re: [PATCH/RFC 01/10] iommu/ipmmu-vmsa: Introduce features, break out alias Geert Uytterhoeven <geert@linux-m68k.org> - 2015-12-16 09:20 +0100

csiph-web